From: Junio C Hamano <gitster@pobox.com>
To: Prarit Bhargava <prarit@redhat.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
git@vger.kernel.org,
"brian m . carlson" <sandals@crustytoothpaste.net>,
"Jeff King" <peff@peff.net>
Subject: Re: [PATCH v2] pretty: add "%aL"|"%al|%cL|%cl" option to output local-part of email addresses
Date: Fri, 25 Oct 2019 14:08:13 +0900 [thread overview]
Message-ID: <xmqqwoctcszm.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <5d9b8cbe-489e-b3eb-873c-4aee2e2015d0@redhat.com> (Prarit Bhargava's message of "Thu, 24 Oct 2019 19:05:00 -0400")
Prarit Bhargava <prarit@redhat.com> writes:
> It can't harm anything to have braces but if the preferred git coding style is
> to only use them when necessary I will remove them.
It harms readability. Don't try to be different just for the sake
of being different, especially when you think "it can't harm
anything" aka "there is no strong reason to do so (or not to)".
Instead, help others by making sure that their eyes do not have to
get distracted for such meaningless differences from existing parts
of the system.
Thanks.
next prev parent reply other threads:[~2019-10-25 5:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 12:53 [PATCH v2] pretty: add "%aL"|"%al|%cL|%cl" option to output local-part of email addresses Prarit Bhargava
2019-10-24 16:16 ` Jeff King
2019-10-24 20:14 ` Prarit Bhargava
2019-10-24 20:29 ` SZEDER Gábor
2019-10-24 23:05 ` Prarit Bhargava
2019-10-25 5:08 ` Junio C Hamano [this message]
2019-10-25 10:56 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwoctcszm.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=prarit@redhat.com \
--cc=sandals@crustytoothpaste.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).