Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Dimitriy <dimitriy.ryazantcev@gmail.com>,
	"brian m. carlson" <sandals@crustytoothpaste.net>,
	"Git Mailing List" <git@vger.kernel.org>,
	"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
	"Jeff King" <peff@peff.net>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v3] l10n: localizable upload progress messages
Date: Mon, 24 Jun 2019 11:04:36 -0700	[thread overview]
Message-ID: <xmqqwohahnbf.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <2074c719-a077-35c4-f30b-769580e17879@kdbg.org> (Johannes Sixt's message of "Sun, 23 Jun 2019 15:10:56 +0200")

Johannes Sixt <j6t@kdbg.org> writes:

> Thanks for educating me. Given your explanations, wouldn't it be much
> more natural to keep the prefix with the unit instead of separating
> them, as the patch does?

Yup, that "octet" comment was illuminating.  Great discussion.

Also I am with Duy's message in the other subthread.  We should keep
the number placeholder "%[udf]" and the unit in a single string),
instead of hardcoding the "a number must come and then unit" in the
code.

Thanks.

  reply	other threads:[~2019-06-24 18:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-22  9:36 [PATCH v3] l10n: localizable upload progress messages Dimitriy Ryazantcev
2019-06-22 11:42 ` Duy Nguyen
2019-06-22 16:39   ` Dimitriy
2019-06-24 18:01     ` Junio C Hamano
2019-06-22 21:42 ` Johannes Sixt
2019-06-23  1:03   ` brian m. carlson
2019-06-23  8:28     ` Dimitriy
2019-06-23 13:10       ` Johannes Sixt
2019-06-24 18:04         ` Junio C Hamano [this message]
2019-06-23 16:58       ` brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwohahnbf.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=dimitriy.ryazantcev@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox