From: Junio C Hamano <gitster@pobox.com>
To: Patrick Hogg <phogg@novamoon.net>
Cc: git@vger.kernel.org, pclouds@gmail.com
Subject: Re: [PATCH] pack-objects.c: Initialize read mutex in cmd_pack_objects
Date: Tue, 22 Jan 2019 15:05:30 -0800 [thread overview]
Message-ID: <xmqqwomwcmyt.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190118022736.36832-1-phogg@novamoon.net> (Patrick Hogg's message of "Thu, 17 Jan 2019 21:27:36 -0500")
Patrick Hogg <phogg@novamoon.net> writes:
> @@ -3319,6 +3327,8 @@ int cmd_pack_objects(int argc, const char **argv, const char *prefix)
> OPT_END(),
> };
>
> + init_read_mutex();
> +
> if (DFS_NUM_STATES > (1 << OE_DFS_STATE_BITS))
> BUG("too many dfs states, increase OE_DFS_STATE_BITS");
>
> @@ -3495,5 +3505,7 @@ int cmd_pack_objects(int argc, const char **argv, const char *prefix)
> _("Total %"PRIu32" (delta %"PRIu32"),"
> " reused %"PRIu32" (delta %"PRIu32")"),
> written, written_delta, reused, reused_delta);
> +
> + cleanup_read_mutex();
This is insufficient, isn't it? There is "return 0" just above the
pre-context of this hunk which should probably be made to "goto
clean_exit" or something, with a new label "clean_exit:" just in
front of this new call to cleaup.
> return 0;
> }
prev parent reply other threads:[~2019-01-22 23:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 2:27 [PATCH] pack-objects.c: Initialize read mutex in cmd_pack_objects Patrick Hogg
2019-01-18 9:21 ` Duy Nguyen
[not found] ` <CAFOcBzmCWBjng_HqFthSrg3eKcEHpQLaa5buKAcm8JHt7EsGdA@mail.gmail.com>
2019-01-18 13:07 ` Fwd: " Patrick Hogg
2019-01-18 13:09 ` Duy Nguyen
2019-01-19 1:46 ` Patrick Hogg
2019-01-18 10:54 ` Johannes Schindelin
2019-01-22 23:05 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwomwcmyt.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=phogg@novamoon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).