From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: test files with same names?
Date: Tue, 04 Sep 2018 10:27:26 -0700 [thread overview]
Message-ID: <xmqqwos19nr5.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CACsJy8B1UDN26tWPvOtixSBiFF6bYP2BtK2n1u4W-tWdVeKK1A@mail.gmail.com> (Duy Nguyen's message of "Mon, 3 Sep 2018 20:16:00 +0200")
Duy Nguyen <pclouds@gmail.com> writes:
> t2000-checkout-cache-clash.sh
> t2001-checkout-cache-clash.sh
These date back to 368f99d5 ("[PATCH 2/2] The core GIT tests: recent
additions and fixes.", 2005-05-13) which later were renamed by
f50c9f76 ("Rename some test scripts and describe the naming
convention", 2005-05-15). One was about checking out a regular file
to a path where a directory currently sits, and the other is about
checking out a regular file that requires a parent directory at a
path where a regular file currently occupies. These days, I suspect
that we would make these into a single "d/f conflict when checking
files out" test script, and f50c9f76 might have been a good chance
to do such a clean-up. If somebody cares deeply enough, I do not
mind seeing a belated clean-up, either.
> t7500-commit.sh
> t7501-commit.sh
> t7502-commit.sh
> t7509-commit.sh
These seem to have organically grown and it is very likely that ones
later introduced were added more from laziness.
If somebody wants to clean them up, probably the first thing to do
is to study them to come up with a clear $test_description for each
of them. I think t7509 says --reset-author and it may have started
as a test on that single feature, but it now covers other ways to
set and/or preserve authorship information, so it may make sense to
update its $test_description to "commit authorship" or something,
for example.
next prev parent reply other threads:[~2018-09-04 17:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 18:16 test files with same names? Duy Nguyen
2018-09-04 17:27 ` Junio C Hamano [this message]
2018-10-23 3:53 ` [PATCH 0/5] Commit test name clean-up Stephen P. Smith
2018-10-23 3:53 ` [PATCH 1/5] t2000: rename and combine checkout clash tests Stephen P. Smith
2018-10-23 3:53 ` [PATCH 2/5] t7509: cleanup description and filename Stephen P. Smith
2018-10-23 4:03 ` Eric Sunshine
2018-10-23 3:53 ` [PATCH 3/5] t7502: rename commit test script to comply with naming convention Stephen P. Smith
2018-10-23 3:53 ` [PATCH 4/5] t7500: rename commit tests " Stephen P. Smith
2018-10-23 4:05 ` Eric Sunshine
2018-10-23 3:53 ` [PATCH 5/5] t7501: rename commit test " Stephen P. Smith
2018-10-23 4:07 ` Eric Sunshine
2018-09-04 18:04 ` test files with same names? Stephen & Linda Smith
2018-09-05 17:25 ` How to handle patch series conflicts Stephen & Linda Smith
2018-09-05 17:27 ` Stefan Beller
2018-09-05 21:16 ` Junio C Hamano
2018-10-08 1:28 ` Stephen & Linda Smith
2018-10-09 5:51 ` Junio C Hamano
2018-10-09 13:11 ` Stephen Smith
2018-09-05 21:34 ` Stephen & Linda Smith
2018-09-05 22:03 ` Stephen & Linda Smith
2018-09-07 0:12 ` Stephen Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwos19nr5.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).