From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr>,
git@vger.kernel.org,
Remi Galan <remi.galan-alfonso@ensimag.grenoble-inp.fr>,
Guillaume Pages <guillaume.pages@ensimag.grenoble-inp.fr>,
Louis-Alexandre Stuber
<louis--alexandre.stuber@ensimag.grenoble-inp.fr>,
Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr>
Subject: Re: [PATCH/RFC v3 2/4] git-am.txt: add configuration section in git am documentation
Date: Wed, 03 Jun 2015 09:42:46 -0700 [thread overview]
Message-ID: <xmqqwpzkyc8p.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <vpq4mmoep9y.fsf@anie.imag.fr> (Matthieu Moy's message of "Wed, 03 Jun 2015 18:21:29 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>> OPTIONS
>> -------
>> (<mbox>|<Maildir>)...::
>> @@ -43,11 +53,11 @@ OPTIONS
>> --keep-non-patch::
>> Pass `-b` flag to 'git mailinfo' (see linkgit:git-mailinfo[1]).
>>
>> ---[no-]keep-cr::
>> +--keep-cr::
>> +--no-keep-cr::
>> With `--keep-cr`, call 'git mailsplit' (see linkgit:git-mailsplit[1])
>> with the same option, to prevent it from stripping CR at the end of
>> - lines. `am.keepcr` configuration variable can be used to specify the
>> - default behaviour.
>
> I don't think it's a good idea to remove this part. If I look for a way
> to make --keep-cr the default, the first place I'd look would be the doc
> for --keep-cr, and I'd appreciate a link to am.keepcr.
Yup, very sensible suggestion. Configuration gives default, command
line options override the default. People come two different ends;
having to describe the same thing twice is wasteful, but will help
them one indirection to find relevant facts in the documentation.
next prev parent reply other threads:[~2015-06-03 16:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 17:34 [PATCH/RFC v3 1/4] git-am.sh: fix initialization of the threeway variable Remi Lespinet
2015-06-02 17:34 ` [PATCH/RFC v3 2/4] git-am.txt: add configuration section in git am documentation Remi Lespinet
2015-06-02 20:16 ` Junio C Hamano
2015-06-03 5:50 ` Torsten Bögershausen
2015-06-03 8:26 ` Remi Lespinet
2015-06-04 5:57 ` Torsten Bögershausen
2015-06-03 16:21 ` Matthieu Moy
2015-06-03 16:42 ` Junio C Hamano [this message]
2015-06-03 17:33 ` Remi Lespinet
2015-06-04 13:26 ` Remi Lespinet
2015-06-02 17:34 ` [PATCH/RFC v3 3/4] t4150-am: refactor am -3 tests Remi Lespinet
2015-06-02 17:34 ` [PATCH/RFC v3 4/4] git-am: add am.threeWay config variable Remi Lespinet
2015-06-02 20:19 ` Junio C Hamano
2015-06-03 16:31 ` Matthieu Moy
2015-06-03 16:43 ` Remi Lespinet
2015-06-02 20:19 ` [PATCH/RFC v3 1/4] git-am.sh: fix initialization of the threeway variable Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwpzkyc8p.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=antoine.delaite@ensimag.grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=guillaume.pages@ensimag.grenoble-inp.fr \
--cc=louis--alexandre.stuber@ensimag.grenoble-inp.fr \
--cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
--cc=remi.lespinet@ensimag.grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox