From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: "Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com>,
Harald Nordgren <haraldnordgren@gmail.com>
Subject: Re: [PATCH v3] range-diff: add --matched-only to skip one-sided commits
Date: Mon, 02 Nov 2026 01:21:14 -0800 [thread overview]
Message-ID: <xmqqy0bblhbp.fsf@gitster.g> (raw)
In-Reply-To: <pull.2401.v3.git.git.1789458703432.gitgitgadget@gmail.com> (Harald Nordgren via GitGitGadget's message of "Tue, 15 Sep 2026 07:51:43 +0000")
"Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Harald Nordgren <haraldnordgren@gmail.com>
>
> Reviewing a range-diff often means scrolling past commits that were
> simply added or dropped, when only the ones that correspond between
> the two ranges are of interest.
>
> --left-only and --right-only already each suppress one of those
> one-sided groups, but they are defined as "only show this side" and
> so cannot be given together, which is exactly why show_range_diff()
> already rejected that combination. Give the "show only the commits
> that correspond on both sides" behavior its own name, --matched-only,
> instead of asking users to reach for a combination that errors out.
>
> Extend the existing '--left-only'/'--right-only' conflict check to
> also reject any combination with --matched-only, since all three
> narrow the output in ways that cannot be combined.
>
> Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
> ---
> range-diff: add --matched-only to skip one-sided commits
>
> Add git range-diff --matched-only to only show commits that correspond
> between the two ranges, skipping ones that were only added or only
> removed.
>
> Changes in v2:
>
> * Update docs and commit message.
> * Use die_for_incompatible_opt3.
This is more than 6 weeks old and looking at the archive, nobody
(including me) was really interested in the topic. Anybody wants to
take a fresh look at the topic?
Unless we see some volunteers to give it a review in a few weeks, I
will discard the topic out of my tree, as 'seen' has been crowded
with topics that have been collecting dust without getting many
reviews.
Thanks.
next prev parent reply other threads:[~2026-11-02 9:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 16:41 [PATCH] range-diff: add --matched-only to skip one-sided commits Harald Nordgren via GitGitGadget
2026-09-11 17:19 ` Junio C Hamano
2026-09-11 18:48 ` Harald Nordgren
2026-09-11 18:52 ` Junio C Hamano
2026-09-11 19:01 ` Harald Nordgren
2026-09-11 19:05 ` Junio C Hamano
2026-09-11 20:55 ` [PATCH v2] " Harald Nordgren via GitGitGadget
2026-09-14 16:33 ` Junio C Hamano
2026-09-15 7:51 ` [PATCH v3] " Harald Nordgren via GitGitGadget
2026-11-02 9:21 ` Junio C Hamano [this message]
2026-11-02 10:05 ` Harald Nordgren
2026-11-02 16:47 ` Ben Knoble
2026-11-02 21:03 ` Harald Nordgren
2026-11-02 21:15 ` Harald Nordgren
2026-11-03 0:01 ` Matt Hunter
2026-11-03 0:16 ` Junio C Hamano
2026-11-03 1:10 ` Ben Knoble
2026-11-03 1:56 ` Matt Hunter
2026-11-03 2:26 ` Junio C Hamano
2026-11-02 22:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy0bblhbp.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=haraldnordgren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox