From: Junio C Hamano <gitster@pobox.com>
To: Igor Wiedler <iwiedler@gitlab.com>
Cc: git@vger.kernel.org, ps@pks.im, peff@peff.net, jltobler@gmail.com
Subject: Re: [PATCH v3 0/2] connected: fix the connectivity check with alternates in deepening fetches
Date: Mon, 19 Oct 2026 16:12:49 -0700 [thread overview]
Message-ID: <xmqqy0btz3m6.fsf@gitster.g> (raw)
In-Reply-To: <20261019110918.71193-1-iwiedler@gitlab.com> (Igor Wiedler's message of "Mon, 19 Oct 2026 13:09:16 +0200")
Igor Wiedler <iwiedler@gitlab.com> writes:
> In a deepening fetch the connectivity check passes "--alternate-refs"
> as a positive revision and walks the alternate's whole history. With a
> 7M-object alternate that takes 227s after a fetch of an empty pack.
>
> Changes since v2:
>
> * The shallow alternate test wrote $TRASH_DIRECTORY into
> objects/info/alternates, which git on Windows cannot resolve. It now
> uses Peff's version with $(pwd) and relative paths.
>
> * The trace tests use $(pwd) instead of $PWD.
>
> No code changes.
>
> v2: https://lore.kernel.org/git/20261014181134.56220-1-iwiedler@gitlab.com/
> v1: https://lore.kernel.org/git/20261014103507.35317-1-iwiedler@gitlab.com/
>
> Igor Wiedler (2):
> connected: negate alternate refs in deepening fetches too
> odb: ignore refs of shallow and grafted alternates
Your patches are not sent as replies to the cover letter of the same
round, which is not how we expect the threads to be structured.
Please study how others' patch threads look like.
Thanks.
next prev parent reply other threads:[~2026-10-19 23:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 10:35 [PATCH] connected: do not walk alternate refs in deepening fetches Igor Wiedler
2026-10-14 12:25 ` Patrick Steinhardt
2026-10-14 16:55 ` Junio C Hamano
2026-10-15 6:41 ` Jeff King
2026-10-14 17:02 ` Justin Tobler
2026-10-14 18:11 ` [PATCH v2 0/2] connected: fix the connectivity check with alternates " Igor Wiedler
2026-10-14 19:23 ` Junio C Hamano
2026-10-19 11:09 ` [PATCH v3 " Igor Wiedler
2026-10-19 23:12 ` Junio C Hamano [this message]
2026-10-20 7:55 ` Igor Wiedler
2026-10-19 11:09 ` [PATCH v3 1/2] connected: negate alternate refs in deepening fetches too Igor Wiedler
2026-10-19 11:09 ` [PATCH v3 2/2] odb: ignore refs of shallow and grafted alternates Igor Wiedler
2026-10-14 18:11 ` [PATCH v2 1/2] connected: negate alternate refs in deepening fetches too Igor Wiedler
2026-10-14 18:11 ` [PATCH v2 2/2] odb: ignore refs of shallow and grafted alternates Igor Wiedler
2026-10-15 6:57 ` Jeff King
2026-10-15 17:25 ` Junio C Hamano
2026-10-16 3:14 ` Jeff King
2026-10-19 11:02 ` Igor Wiedler
2026-10-18 1:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy0btz3m6.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=iwiedler@gitlab.com \
--cc=jltobler@gmail.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox