From: Junio C Hamano <gitster@pobox.com>
To: "Mathias Rav" <m@git.strova.dk>
Cc: git@vger.kernel.org, "Phillip Wood" <phillip.wood@dunelm.org.uk>,
"John Cai" <johncai86@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
"Patrick Steinhardt" <ps@pks.im>,
"Karthik Nayak" <karthik.188@gmail.com>,
"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
Subject: Re: [PATCH v2] merge-file: fix BUG when --object-id is used in a worktree
Date: Wed, 18 Mar 2026 12:45:54 -0700 [thread overview]
Message-ID: <xmqqy0joq5u5.fsf@gitster.g> (raw)
In-Reply-To: <94dd3222-42bc-42af-8d97-5bd471a86fcd@app.fastmail.com> (Mathias Rav's message of "Wed, 18 Mar 2026 19:16:06 +0000")
"Mathias Rav" <m@git.strova.dk> writes:
> On Wed, Mar 11, 2026, at 6:44 AM, Mathias Rav wrote:
>> Thanks Karthik, Patrick, Kristoffer and Junio for your feedback.
>> I've incorporated the sum of it all in this PATCH v2:
>>
>> - Check !repo before object_id and add a comment
>> - Use term "linked worktree" instead of just "worktree" throughout
>> - Use git -C instead of a subshell in test
>> - Remove gitk's quotes from the commit references in the commit message
>
> I'm unsure of the process from here for a small bugfix like this.
> I believe I followed the SubmittingPatches document
> by sending a PATCH v2 with To: Junio, Cc: list and others.
> Do I need to do anything else to see this patch eventually land in Junio's tree?
Pinging like this was absolutely the right thing to do in this case,
as the patch fell through the cracks. Will apply (assuming that
everybody involved in the review is now happy with this iteration).
Thanks.
next prev parent reply other threads:[~2026-03-18 19:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 11:46 [PATCH] merge-file: fix BUG when --object-id is used in a worktree Mathias Rav
2026-03-10 12:35 ` Karthik Nayak
2026-03-10 12:49 ` Patrick Steinhardt
2026-03-10 20:01 ` Junio C Hamano
2026-03-11 6:44 ` [PATCH v2] " Mathias Rav
2026-03-11 7:18 ` Kristoffer Haugsbakk
2026-03-11 11:14 ` Kristoffer Haugsbakk
2026-03-11 17:26 ` Junio C Hamano
2026-03-11 20:16 ` Kristoffer Haugsbakk
2026-03-18 19:40 ` Junio C Hamano
2026-03-18 19:16 ` Mathias Rav
2026-03-18 19:45 ` Junio C Hamano [this message]
2026-03-10 13:34 ` [PATCH] " Kristoffer Haugsbakk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy0joq5u5.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=johncai86@gmail.com \
--cc=karthik.188@gmail.com \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=m@git.strova.dk \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox