git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "D. Ben Knoble" <ben.knoble@gmail.com>
Cc: git@vger.kernel.org,  Jeff King <peff@peff.net>,
	 Han Jiang <jhcarl0814@gmail.com>
Subject: Re: [PATCH] config: really pretend missing :(optional) value is not there
Date: Thu, 20 Nov 2025 14:40:53 -0800	[thread overview]
Message-ID: <xmqqy0o05nuy.fsf@gitster.g> (raw)
In-Reply-To: <CALnO6CC0HU60F47yoE45ei7_K2_MeLRS7fihMPn+f8top7Jr7w@mail.gmail.com> (D. Ben Knoble's message of "Thu, 20 Nov 2025 17:15:46 -0500")

"D. Ben Knoble" <ben.knoble@gmail.com> writes:

>>  config.c                   |  1 +
>>  t/t1311-config-optional.sh | 36 ++++++++++++++++++++++++++++++
>>  3 files changed, 73 insertions(+), 9 deletions(-)
>
> This needs a tweak to Meson, probably in t/meson.build, for the new
> test script. Otherwise Meson-based packages (like Gentoo) won't build.

Yup.

diff --git a/t/meson.build b/t/meson.build
index bbeba1a8d5..137c0caea0 100644
--- a/t/meson.build
+++ b/t/meson.build
@@ -182,6 +182,7 @@ integration_tests = [
   't1308-config-set.sh',
   't1309-early-config.sh',
   't1310-config-default.sh',
+  't1311-config-optional.sh',
   't1350-config-hooks-path.sh',
   't1400-update-ref.sh',
   't1401-symbolic-ref.sh',

      reply	other threads:[~2025-11-20 22:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20 19:34 [PATCH] config: really pretend missing :(optional) value is not there Junio C Hamano
2025-11-20 19:45 ` [PATCH] config: really treat missing optional path as not configured Junio C Hamano
2025-11-20 22:15 ` [PATCH] config: really pretend missing :(optional) value is not there D. Ben Knoble
2025-11-20 22:40   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy0o05nuy.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jhcarl0814@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).