From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: <git@vger.kernel.org>, Jeff King <peff@peff.net>,
Martin Wilck <mwilck@suse.com>,
Adrian Schroeter <adrian@suse.com>
Subject: Re: [PATCH v2 1/2] object-file: disallow adding submodules of different hash algo
Date: Sat, 15 Nov 2025 11:53:22 -0800 [thread overview]
Message-ID: <xmqqy0o7dqdp.fsf@gitster.g> (raw)
In-Reply-To: <20251115005818.2271557-1-sandals@crustytoothpaste.net> (brian m. carlson's message of "Sat, 15 Nov 2025 00:58:17 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> object-file.c | 6 +++++-
> t/t3700-add.sh | 25 +++++++++++++++++++++++++
> t/t7400-submodule-basic.sh | 25 +++++++++++++++++++++++++
> 3 files changed, 55 insertions(+), 1 deletion(-)
Updated test reads much nicer. Thanks for updating them.
next prev parent reply other threads:[~2025-11-15 19:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 12:58 git fails to checkout SHA1 submodule in SHA256 repo with --depth=1 Martin Wilck
2025-11-12 16:32 ` Junio C Hamano
2025-11-12 23:37 ` brian m. carlson
2025-11-13 10:15 ` Martin Wilck
2025-11-13 22:51 ` brian m. carlson
2025-11-13 22:57 ` Martin Wilck
2025-11-14 22:55 ` Marc Branchaud
2025-11-15 20:14 ` brian m. carlson
2025-11-12 23:54 ` [PATCH] object-file: disallow adding submodules of different hash algo brian m. carlson
2025-11-13 3:26 ` Jeff King
2025-11-13 3:56 ` Jeff King
2025-11-13 16:29 ` Junio C Hamano
2025-11-14 23:26 ` brian m. carlson
2025-11-15 1:53 ` Jeff King
2025-11-13 23:15 ` brian m. carlson
2025-11-15 0:58 ` [PATCH v2 1/2] " brian m. carlson
2025-11-15 0:58 ` [PATCH v2 2/2] read-cache: drop submodule check from add_to_cache() brian m. carlson
2025-11-15 19:57 ` Junio C Hamano
2025-11-15 20:06 ` brian m. carlson
2025-11-15 19:53 ` Junio C Hamano [this message]
2025-11-17 8:53 ` [PATCH v2 1/2] object-file: disallow adding submodules of different hash algo Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy0o7dqdp.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=adrian@suse.com \
--cc=git@vger.kernel.org \
--cc=mwilck@suse.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).