From: Junio C Hamano <gitster@pobox.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>, Jeff King <peff@peff.net>,
Joe Drew <joe.drew@indexexchange.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: "lock file exists" when fetching in bare clone of repository
Date: Thu, 28 Aug 2025 09:16:48 -0700 [thread overview]
Message-ID: <xmqqy0r3whe7.fsf@gitster.g> (raw)
In-Reply-To: <CAOLa=ZRizMKRsP2wo-RJUksXAv1Hgx3XDGCO_ZGOwKpf6kAbQQ@mail.gmail.com> (Karthik Nayak's message of "Thu, 28 Aug 2025 06:51:18 -0700")
Karthik Nayak <karthik.188@gmail.com> writes:
> This error type is bubbled up to `files_transaction_prepare()` which
> tries to lock each reference update by calling `lock_ref_for_update()`.
> So if the locking fails, we check if the rejection type can be ignored,
> which is done by calling `ref_transaction_maybe_set_rejected()`.
>
> Only during batched updates would errors be ignore and only for
> non-generic errors. So this change would specifically only apply for
> batched updates. Currently that is used by:
>
> 1. git fetch
> 2. git receive-pack
> 3. git update-ref --batch-updates
>
> And for all three scenarios I think it makes sense to add this in.
Thanks for an extra explanation.
These pieces of information would be necessary in the proposed log
message when it becomes a real patch.
next prev parent reply other threads:[~2025-08-28 16:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 20:54 "lock file exists" when fetching in bare clone of repository Joe Drew
2025-08-20 21:33 ` Jeff King
2025-08-21 7:15 ` Patrick Steinhardt
2025-08-21 7:27 ` Jeff King
2025-08-21 10:09 ` Patrick Steinhardt
2025-08-21 16:05 ` Junio C Hamano
2025-08-22 6:13 ` Patrick Steinhardt
2025-08-22 8:01 ` Karthik Nayak
2025-08-22 17:47 ` Junio C Hamano
2025-08-28 13:51 ` Karthik Nayak
2025-08-28 16:16 ` Junio C Hamano [this message]
2025-09-01 18:17 ` Karthik Nayak
2025-08-21 15:47 ` Junio C Hamano
2025-08-22 13:28 ` Joe Drew
2025-08-26 11:19 ` Jeff King
2025-09-02 10:55 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy0r3whe7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=joe.drew@indexexchange.com \
--cc=karthik.188@gmail.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).