From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] revert: initialize const value
Date: Mon, 04 Aug 2025 07:26:18 -0700 [thread overview]
Message-ID: <xmqqy0rz88ol.fsf@gitster.g> (raw)
In-Reply-To: <aJC3OiJoqJRnR_My@pks.im> (Patrick Steinhardt's message of "Mon, 4 Aug 2025 15:35:54 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> Initializing the value feels like a pragmatic choice to me. There is no
> downside, and anyone who might be puzzled by the comment is likely to
> git-blame(1) to your commit anyway. So I think the current version is
> good enough.
I had to run "git blame" to find out who was being overly clever by
using a sentinel like this. I am glad that it was not me ;-)
The fix looks good. It may make it even better if we renamed the
variable to sentinel_address or something ;-).
prev parent reply other threads:[~2025-08-04 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 13:00 [PATCH] revert: initialize const value Jeff King
2025-08-04 13:01 ` Jeff King
2025-08-04 13:35 ` Patrick Steinhardt
2025-08-04 13:51 ` Phillip Wood
2025-08-04 14:26 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy0rz88ol.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).