git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org,  Karthik Nayak <karthik.188@gmail.com>
Subject: Re: [PATCH v2 08/13] builtin/show-ref: don't fetch objects when printing refs
Date: Mon, 28 Apr 2025 14:50:10 -0700	[thread overview]
Message-ID: <xmqqy0vk9crx.fsf@gitster.g> (raw)
In-Reply-To: <20250425-pks-object-store-cleanups-v2-8-63f1695b7700@pks.im> (Patrick Steinhardt's message of "Fri, 25 Apr 2025 09:08:59 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> When printing references via git-show-ref(1) we double check that their
> respective object IDs point to an existing object. This check is
> performed via `repo_has_object_file()`, which knows to fetch missing
> promised objects in the background. We shouldn't have a need to fetch
> such objects though as no reference should ever point to a missing
> object at all.

But hasn't the earlier part of this series made sure that asking
has_object() without an extra flag would make it say "no" if the
object that we know we can obtain is kept in our promisor remote
to be lazily fetched?  Or am I missing some other mechanism to make
sure that somebody does any necessary lazy fetching of an object
before we point our refs at it?

Thanks.

  reply	other threads:[~2025-04-28 21:50 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-23  7:48 [PATCH 00/13] object-store: a handful of cleanups Patrick Steinhardt
2025-04-23  7:48 ` [PATCH 01/13] object-store: move `struct packed_git` into "packfile.h" Patrick Steinhardt
2025-04-23  7:48 ` [PATCH 02/13] object-store: drop `loose_object_path()` Patrick Steinhardt
2025-04-23  7:48 ` [PATCH 03/13] object-store: move and rename `odb_pack_keep()` Patrick Steinhardt
2025-04-23 10:03   ` Karthik Nayak
2025-04-23  7:48 ` [PATCH 04/13] object-store: move function declarations to their respective subsystems Patrick Steinhardt
2025-04-23  7:48 ` [PATCH 05/13] object-store: allow fetching objects via `has_object()` Patrick Steinhardt
2025-04-23 10:07   ` Karthik Nayak
2025-04-23  7:48 ` [PATCH 06/13] treewide: trivial conversions of `repo_has_object_file()` Patrick Steinhardt
2025-04-23  7:48 ` [PATCH 07/13] builtin/index-pack: don't fetch promised objects for collision check Patrick Steinhardt
2025-04-23 17:08   ` Karthik Nayak
2025-04-25  7:04     ` Patrick Steinhardt
2025-04-28 19:48       ` Karthik Nayak
2025-04-23  7:48 ` [PATCH 08/13] builtin/show-ref: don't fetch objects when printing refs Patrick Steinhardt
2025-04-23  7:48 ` [PATCH 09/13] refs: don't fetch promisor objects in `ref_resolves_to_object()` Patrick Steinhardt
2025-04-23 17:11   ` Karthik Nayak
2025-04-23  7:48 ` [PATCH 10/13] http-walker: don't fetch objects via promisor remotes Patrick Steinhardt
2025-04-23  7:48 ` [PATCH 11/13] list-objects: clarify how promised blobs are excluded Patrick Steinhardt
2025-04-23  7:48 ` [PATCH 12/13] bulk-checkin: don't fetch promised objects on write Patrick Steinhardt
2025-04-23  7:48 ` [PATCH 13/13] object-store: drop `repo_has_object_file()` Patrick Steinhardt
2025-04-23 17:20 ` [PATCH 00/13] object-store: a handful of cleanups Karthik Nayak
2025-04-25  7:07   ` Patrick Steinhardt
2025-04-25  7:08 ` [PATCH v2 " Patrick Steinhardt
2025-04-25  7:08   ` [PATCH v2 01/13] object-store: move `struct packed_git` into "packfile.h" Patrick Steinhardt
2025-04-25  7:08   ` [PATCH v2 02/13] object-store: drop `loose_object_path()` Patrick Steinhardt
2025-04-25  7:08   ` [PATCH v2 03/13] object-store: move and rename `odb_pack_keep()` Patrick Steinhardt
2025-04-25  7:08   ` [PATCH v2 04/13] object-store: move function declarations to their respective subsystems Patrick Steinhardt
2025-04-25  7:08   ` [PATCH v2 05/13] object-store: allow fetching objects via `has_object()` Patrick Steinhardt
2025-04-25  7:08   ` [PATCH v2 06/13] treewide: trivial conversions of `repo_has_object_file()` Patrick Steinhardt
2025-04-28 21:40     ` Junio C Hamano
2025-04-25  7:08   ` [PATCH v2 07/13] builtin/index-pack: don't fetch promised objects for collision check Patrick Steinhardt
2025-04-28 21:46     ` Junio C Hamano
2025-04-29  6:15       ` Patrick Steinhardt
2025-04-25  7:08   ` [PATCH v2 08/13] builtin/show-ref: don't fetch objects when printing refs Patrick Steinhardt
2025-04-28 21:50     ` Junio C Hamano [this message]
2025-04-25  7:09   ` [PATCH v2 09/13] refs: don't fetch promisor objects in `ref_resolves_to_object()` Patrick Steinhardt
2025-04-28 21:53     ` Junio C Hamano
2025-04-25  7:09   ` [PATCH v2 10/13] http-walker: don't fetch objects via promisor remotes Patrick Steinhardt
2025-04-28 21:56     ` Junio C Hamano
2025-04-25  7:09   ` [PATCH v2 11/13] list-objects: clarify how promised blobs are excluded Patrick Steinhardt
2025-04-25  7:09   ` [PATCH v2 12/13] bulk-checkin: don't fetch promised objects on write Patrick Steinhardt
2025-04-28 22:07     ` Junio C Hamano
2025-04-29  6:15       ` Patrick Steinhardt
2025-04-29 15:25         ` Junio C Hamano
2025-04-25  7:09   ` [PATCH v2 13/13] object-store: drop `repo_has_object_file()` Patrick Steinhardt
2025-04-28 19:49   ` [PATCH v2 00/13] object-store: a handful of cleanups Karthik Nayak
2025-04-29  7:52 ` [PATCH v3 0/7] " Patrick Steinhardt
2025-04-29  7:52   ` [PATCH v3 1/7] object-store: move `struct packed_git` into "packfile.h" Patrick Steinhardt
2025-04-29  7:52   ` [PATCH v3 2/7] object-store: drop `loose_object_path()` Patrick Steinhardt
2025-04-29  7:52   ` [PATCH v3 3/7] object-store: move and rename `odb_pack_keep()` Patrick Steinhardt
2025-04-29  7:52   ` [PATCH v3 4/7] object-store: move function declarations to their respective subsystems Patrick Steinhardt
2025-04-29  7:52   ` [PATCH v3 5/7] object-store: allow fetching objects via `has_object()` Patrick Steinhardt
2025-04-29  7:52   ` [PATCH v3 6/7] treewide: convert users of `repo_has_object_file()` to `has_object()` Patrick Steinhardt
2025-04-29  7:52   ` [PATCH v3 7/7] object-store: drop `repo_has_object_file()` Patrick Steinhardt
2025-04-29 20:07   ` [PATCH v3 0/7] object-store: a handful of cleanups Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy0vk9crx.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).