* [PATCH] environment: fix typo: 'setup_git_directory_gently'
@ 2025-04-18 18:58 Abhijeet Sonar
2025-04-18 21:04 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Abhijeet Sonar @ 2025-04-18 18:58 UTC (permalink / raw)
To: git; +Cc: Abhijeet Sonar
From: Abhijeet Sonar <abhijeet.nkt@gmail.com>
Above the declaration of git_work_tree_cfg, we have:
/* This is set by setup_git_dir_gently() and/or git_default_config() */
char *git_work_tree_cfg;
It can be verified that there is no function called
'setup_git_dir_gently' by running grep on the codebase:
$ grep -R setup_git_dir_gently .
./environment.c:/* This is set by setup_git_dir_gently() and/or git_default_config() */
The comment, introduced in e90fdc39b6 (Clean up work-tree handling), is
the only occurrence of the name 'setup_git_dir_gently'.
It probably meant 'setup_git_directory_gently' as that is a name of a
real function in setup.c. Correct it.
Signed-off-by: Abhijeet Sonar <abhijeet.nkt@gmail.com>
---
environment.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/environment.c b/environment.c
index 3c32367c28..970a407753 100644
--- a/environment.c
+++ b/environment.c
@@ -106,7 +106,7 @@ int auto_comment_line_char;
/* Parallel index stat data preload? */
int core_preload_index = 1;
-/* This is set by setup_git_dir_gently() and/or git_default_config() */
+/* This is set by setup_git_directory_gently() and/or git_default_config() */
char *git_work_tree_cfg;
/*
--
2.49.0-rc0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] environment: fix typo: 'setup_git_directory_gently'
2025-04-18 18:58 [PATCH] environment: fix typo: 'setup_git_directory_gently' Abhijeet Sonar
@ 2025-04-18 21:04 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2025-04-18 21:04 UTC (permalink / raw)
To: Abhijeet Sonar; +Cc: git
Abhijeet Sonar <abhijeet.nkt@gmail.com> writes:
> From: Abhijeet Sonar <abhijeet.nkt@gmail.com>
>
> Above the declaration of git_work_tree_cfg, we have:
>
> /* This is set by setup_git_dir_gently() and/or git_default_config() */
> char *git_work_tree_cfg;
>
> It can be verified that there is no function called
> 'setup_git_dir_gently' by running grep on the codebase:
>
> $ grep -R setup_git_dir_gently .
> ./environment.c:/* This is set by setup_git_dir_gently() and/or git_default_config() */
>
> The comment, introduced in e90fdc39b6 (Clean up work-tree handling), is
> the only occurrence of the name 'setup_git_dir_gently'.
>
> It probably meant 'setup_git_directory_gently' as that is a name of a
> real function in setup.c. Correct it.
>
> Signed-off-by: Abhijeet Sonar <abhijeet.nkt@gmail.com>
> ---
> environment.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Will queue. Thanks for a well-written patch.
> diff --git a/environment.c b/environment.c
> index 3c32367c28..970a407753 100644
> --- a/environment.c
> +++ b/environment.c
> @@ -106,7 +106,7 @@ int auto_comment_line_char;
> /* Parallel index stat data preload? */
> int core_preload_index = 1;
>
> -/* This is set by setup_git_dir_gently() and/or git_default_config() */
> +/* This is set by setup_git_directory_gently() and/or git_default_config() */
> char *git_work_tree_cfg;
>
> /*
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-18 21:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-18 18:58 [PATCH] environment: fix typo: 'setup_git_directory_gently' Abhijeet Sonar
2025-04-18 21:04 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).