git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: What's cooking in git.git (Mar 2025, #04; Fri, 14)
Date: Fri, 14 Mar 2025 17:02:50 -0700	[thread overview]
Message-ID: <xmqqy0x7cg9h.fsf@gitster.g> (raw)
In-Reply-To: <20250314184130.GA578421@coredump.intra.peff.net> (Jeff King's message of "Fri, 14 Mar 2025 14:41:30 -0400")

Jeff King <peff@peff.net> writes:

> On Fri, Mar 14, 2025 at 10:36:39AM -0700, Junio C Hamano wrote:
>
>> * ps/ci-meson-check-build-docs (2025-03-12) 1 commit
>>  - ci: perform build and smoke tests for Meson docs
>> 
>>  CI update.
>> 
>>  Will merge to 'next'.
>>  source: <20250312-b4-pks-ci-meson-docs-v1-1-5e7cf7ac959a@pks.im>
>
> I didn't dig into it, but I'd imagine this topic is the source of CI
> failures on the "documentation" job like this:
>
>   2025-03-14T17:50:13.8749066Z + meson setup build-asciidoc -Ddocs=html,man -Ddocs_backend=asciidoc
>   2025-03-14T17:50:13.8752287Z ci/test-documentation.sh: line 50: meson: command not found
>   2025-03-14T17:50:13.8769502Z ##[error]Process completed with exit code 127.
>
> that I'm seeing in jch (and looks like you have a similar one in the
> latest build of 'seen')
>
> -Peff

Somebody more clueful than me about how the CI dependency set-up is
supposed to happen should rewrite the proposed log message
altogether.  The install-dependencies script pretends as if two
case..esac blocks are orthogonal (the former switches on $distro,
the latter that we see in the patch switches on $jobname), but I
somehow do not get the feeling that we can move Documentation job
from ubuntu-latest to alpine-latest for example.

In any case, the change seems to "fix" the issue for me

(bad)
https://github.com/git/git/actions/runs/13867157977/job/38808418127

(good)
https://github.com/git/git/actions/runs/13867208725/job/38808554478


Thanks.

--- >8 ---
Subject: [PATCH] install meson for Documentation job

Why should we even do this?  Doesn't it run on ubuntu-latest which
has its own apt--get install for meson in the $distro specific
set-up before this part?


---
 ci/install-dependencies.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
index 0df74610d0..fdeeaabaca 100755
--- a/ci/install-dependencies.sh
+++ b/ci/install-dependencies.sh
@@ -123,7 +123,7 @@ sparse)
 	;;
 Documentation)
 	sudo apt-get -q update
-	sudo apt-get -q -y install asciidoc xmlto docbook-xsl-ns make
+	sudo apt-get -q -y install asciidoc xmlto docbook-xsl-ns make meson
 
 	test -n "$ALREADY_HAVE_ASCIIDOCTOR" ||
 	sudo gem install --version 1.5.8 asciidoctor
-- 
2.49.0-205-gbb947d5b2d


  parent reply	other threads:[~2025-03-15  0:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-14 17:36 What's cooking in git.git (Mar 2025, #04; Fri, 14) Junio C Hamano
2025-03-14 18:41 ` Jeff King
2025-03-14 18:42   ` Jeff King
2025-03-15  0:02   ` Junio C Hamano [this message]
2025-03-18 15:57     ` [PATCH] install meson for Documentation job Junio C Hamano
2025-03-18 16:19       ` Karthik Nayak
2025-03-18 20:40         ` Junio C Hamano
2025-03-19  9:24           ` Patrick Steinhardt
2025-03-19 16:22             ` Karthik Nayak
2025-03-19 16:33             ` [PATCH] ci/github: add missing 'CI_JOB_IMAGE' env variable Karthik Nayak
2025-03-20  7:10               ` Patrick Steinhardt
2025-03-21  7:51               ` Junio C Hamano
2025-03-20 20:27             ` [PATCH] install meson for Documentation job Junio C Hamano
2025-03-15  0:32 ` en/diff-rename-follow-fix (Was: Re: What's cooking in git.git (Mar 2025, #04; Fri, 14)) Elijah Newren
2025-03-15  1:22   ` en/diff-rename-follow-fix Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy0x7cg9h.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).