git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: git@vger.kernel.org,  Caleb White <cdwhite3@pm.me>
Subject: Re: What's cooking in git.git (Nov 2024, #10; Thu, 28)
Date: Mon, 02 Dec 2024 09:39:06 +0900	[thread overview]
Message-ID: <xmqqy10ylxzp.fsf@gitster.g> (raw)
In-Reply-To: <fbda37b9-41e7-4b18-a831-dfb5a9a9c54f@gmail.com> (Phillip Wood's message of "Thu, 28 Nov 2024 15:34:40 +0000")

Phillip Wood <phillip.wood123@gmail.com> writes:

> Hi Junio
>
> On 28/11/2024 05:35, Junio C Hamano wrote:
>> * cw/worktree-extension (2024-11-26) 8 commits
>>   - worktree: refactor `repair_worktree_after_gitdir_move()`
>>   - worktree: add relative cli/config options to `repair` command
>>   - worktree: add relative cli/config options to `move` command
>>   - worktree: add relative cli/config options to `add` command
>>   - worktree: add `write_worktree_linking_files()` function
>>   - worktree: refactor infer_backlink return
>>   - worktree: add `relativeWorktrees` extension
>>   - setup: correctly reinitialize repository version
>>   Introduce a new repository extension to prevent older Git versions
>>   from mis-interpreting worktrees created with relative paths.
>>   Will merge to 'next'?
>>   source: <20241125-wt_relative_options-v5-0-356d122ff3db@pm.me>
>
> I've had a look at the range-diff for the latest version and had a
> query about the removal of a check from one of the tests[1]. Perhaps
> we should wait to hear from Caleb about that, but if you're keen to
> get these merged down in time for the next release we could just fix
> up the test later if it turns out to be necessary - I think the code
> changes are all fine.

Thanks for reviewing (and thanks Caleb for working on) this topic.
I see the latest iteration v6 has added back the extension checking,
so we probably are good to go.



  reply	other threads:[~2024-12-02  0:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-28  5:35 What's cooking in git.git (Nov 2024, #10; Thu, 28) Junio C Hamano
2024-11-28 15:34 ` Phillip Wood
2024-12-02  0:39   ` Junio C Hamano [this message]
2024-11-28 16:11 ` Patrick Steinhardt
2024-12-02  0:48   ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2024-11-28 21:40 Caleb White
2024-12-02  2:48 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy10ylxzp.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=cdwhite3@pm.me \
    --cc=git@vger.kernel.org \
    --cc=phillip.wood123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).