git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH] ci: remove 'Upload failed tests' directories' step from linux32 jobs
Date: Mon, 09 Sep 2024 16:00:20 -0700	[thread overview]
Message-ID: <xmqqy140o2kb.fsf@gitster.g> (raw)

Linux32 jobs seem to be getting:

    Error: This request has been automatically failed because it uses a
    deprecated version of `actions/upload-artifact: v1`. Learn more:
    https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

before doing anything useful.  For now, disable the step.

Ever since actions/upload-artifact@v1 got disabled, mentioning the
offending version of it seems to stop anything from happening.  At
least this should run the same build and test.

See

    https://github.com/git/git/actions/runs/10780030750/job/29894867249

for example.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 .github/workflows/main.yml | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 1ee0433acc..97f9b06310 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -365,12 +365,6 @@ jobs:
       with:
         name: failed-tests-${{matrix.vector.jobname}}
         path: ${{env.FAILED_TEST_ARTIFACTS}}
-    - name: Upload failed tests' directories
-      if: failure() && env.FAILED_TEST_ARTIFACTS != '' && matrix.vector.jobname == 'linux32'
-      uses: actions/upload-artifact@v1 # cannot be upgraded because Node.js Actions aren't supported in this container
-      with:
-        name: failed-tests-${{matrix.vector.jobname}}
-        path: ${{env.FAILED_TEST_ARTIFACTS}}
   static-analysis:
     needs: ci-config
     if: needs.ci-config.outputs.enabled == 'yes'
-- 
2.46.0-701-g65fb39cb77


             reply	other threads:[~2024-09-09 23:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-09 23:00 Junio C Hamano [this message]
2024-09-11 22:32 ` [PATCH] ci: remove 'Upload failed tests' directories' step from linux32 jobs Junio C Hamano
2024-09-12  7:56   ` Jeff King
2024-09-12  8:00     ` Jeff King
2024-09-12  9:42       ` [PATCH 0/4] make linux32 ci job work with recent actions Jeff King
2024-09-12  9:43         ` [PATCH 1/4] ci: drop run-docker scripts Jeff King
2024-09-12 10:40           ` Patrick Steinhardt
2024-09-12  9:45         ` [PATCH 2/4] ci: unify ubuntu and ubuntu32 dependencies Jeff King
2024-09-12 10:41           ` Patrick Steinhardt
2024-09-12  9:47         ` [PATCH 3/4] ci: use more recent linux32 image Jeff King
2024-09-12 10:41           ` Patrick Steinhardt
2024-09-12 11:22             ` Jeff King
2024-09-12 11:53               ` Patrick Steinhardt
2024-09-12 12:47                 ` Patrick Steinhardt
2024-09-13  4:55                   ` Jeff King
2024-09-13  5:39                     ` Patrick Steinhardt
2024-09-12  9:48         ` [PATCH 4/4] ci: use regular action versions for linux32 job Jeff King
2024-09-12 19:41         ` [PATCH 0/4] make linux32 ci job work with recent actions Junio C Hamano
2024-09-13  5:52         ` [PATCH 5/4] ci: add Ubuntu 16.04 job to GitLab CI Patrick Steinhardt
2024-09-13  6:21           ` Jeff King
2024-09-13  6:39             ` Patrick Steinhardt
2024-09-13  6:43               ` Jeff King
2024-09-13  6:47                 ` Patrick Steinhardt
2024-09-13 16:17             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy140o2kb.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).