From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] Revert "reflog expire: don't use lookup_commit_reference_gently()"
Date: Wed, 17 Jul 2024 07:56:20 -0700 [thread overview]
Message-ID: <xmqqy1605ap7.fsf@gitster.g> (raw)
In-Reply-To: <20240717054555.GA547635@coredump.intra.peff.net> (Jeff King's message of "Wed, 17 Jul 2024 01:45:55 -0400")
Jeff King <peff@peff.net> writes:
> It does make me wonder if there other gaps for reflogs that point to
> non-commits. E.g., if I have a tag pointing to a blob, would we save its
> reflog entry if a reachable commit points to that blob?. I suspect not,
> as the full reachability check is very expensive.
reflog.c:should_expire_reflog_ent() says that anything that is not a
commit should be expired without doing the unreachable() check, and
the UE_ALWAYS flag used for that is set by the function in question.
This arrangement has stayed the same since daf1d828 (reflog expire:
don't use lookup_commit_reference_gently(), 2021-12-22).
Thanks.
prev parent reply other threads:[~2024-07-17 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 19:56 [PATCH] Revert "reflog expire: don't use lookup_commit_reference_gently()" Junio C Hamano
2024-07-17 5:45 ` Jeff King
2024-07-17 14:56 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy1605ap7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).