From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Tiago de Bem Natel de Moura <t.nateldemoura@gmail.com>,
git@vger.kernel.org
Subject: Re: git diff-tree do not honor diff.orderfile config
Date: Sat, 06 Jul 2024 15:10:00 -0700 [thread overview]
Message-ID: <xmqqy16ematj.fsf@gitster.g> (raw)
In-Reply-To: <Zohf7LzaRHaG9vX6@nand.local> (Taylor Blau's message of "Fri, 5 Jul 2024 17:04:44 -0400")
Taylor Blau <me@ttaylorr.com> writes:
> So I suppose the question is whether supporting -O from diff-tree is
> sensible. If it is, then reading the diff.orderFile configuration option
> is a no-brainer. But if it isn't, then we should probably not make a bad
> situation worse by adding support for it.
If plumbing commands paid attention to the end-user configuration,
they will not serve as a reliable building blocks for script
writers. The would instead change their behaviour in a way not
expected by script writers.
On the other hand, we do want to give script writers an option to
utilize power of the underlying machinery. If they want to specify
a particular order of paths in the output, they are welcome to feed
an orderfile via the command line and that is why we have an option.
Supporting "-O <orderfile>" and ignoring "diff.orderfile" are both
very sensible thing for the plumbing commands and it is the result
of deliberate design.
Thanks.
next prev parent reply other threads:[~2024-07-06 22:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 10:28 git diff-tree do not honor diff.orderfile config Tiago de Bem Natel de Moura
2024-07-05 21:04 ` Taylor Blau
2024-07-06 7:02 ` Jeff King
2024-07-06 22:10 ` Junio C Hamano [this message]
2024-07-08 12:49 ` Tiago de Bem Natel de Moura
2024-07-06 7:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy16ematj.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=t.nateldemoura@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).