From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Stefan Metzmacher <metze@samba.org>,
git@vger.kernel.org, Derrick Stolee <stolee@gmail.com>
Subject: Re: safe.directory wildcards
Date: Fri, 31 May 2024 07:49:18 -0700 [thread overview]
Message-ID: <xmqqy17qhw9d.fsf@gitster.g> (raw)
In-Reply-To: <ZlmH1CFZWHokAqso@tanuki> (Patrick Steinhardt's message of "Fri, 31 May 2024 10:18:28 +0200")
Patrick Steinhardt <ps@pks.im> writes:
>> I am reluctant to use wildmatch() but I would expect that in
>> practice "leading path matches" (in other words, "everything under
>> this directory is OK") is sufficient, perhaps?
>
> Is there any particular reason why you don't want to use wildmatch?
Mostly out of the principle to avoid anything more complex than
absolutely necessary in a security relevant code path.
It is called "superstition" in other languages ;-).
prev parent reply other threads:[~2024-05-31 14:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 9:08 safe.directory wildcards Stefan Metzmacher
2024-05-29 16:02 ` Junio C Hamano
2024-05-29 16:35 ` Konstantin Ryabitsev
2024-05-29 18:15 ` Stefan Metzmacher
2024-05-31 8:18 ` Patrick Steinhardt
2024-05-31 14:35 ` Chris Torek
2024-05-31 14:49 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy17qhw9d.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=metze@samba.org \
--cc=ps@pks.im \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).