From: Junio C Hamano <gitster@pobox.com>
To: Dragan Simic <dsimic@manjaro.org>
Cc: git@vger.kernel.org, rjusto@gmail.com, sunshine@sunshineco.com
Subject: Re: [PATCH v2] doc: imply that interactive.singleKey is disabled by default
Date: Wed, 22 May 2024 14:31:26 -0700 [thread overview]
Message-ID: <xmqqy1811qkx.fsf@gitster.g> (raw)
In-Reply-To: <7da73f15a018d858519eefa373001ccb3eaf32e2.1716412958.git.dsimic@manjaro.org> (Dragan Simic's message of "Wed, 22 May 2024 23:24:43 +0200")
Dragan Simic <dsimic@manjaro.org> writes:
> 1: 3141fe9f7328 ! 1: 7da73f15a018 doc: note that interactive.singleKey is disabled by default
> @@ Metadata
> Author: Dragan Simic <dsimic@manjaro.org>
>
> ## Commit message ##
> - doc: note that interactive.singleKey is disabled by default
> + doc: imply that interactive.singleKey is disabled by default
>
> Make it clear that the interactive.singleKey configuration option is disabled
Heh, "note that" would probably be better, as we are going to say
"Make it clear" anyway, no? That is stronger than just to imply.
Keeping the original version of the log message probably was
sufficient.
> + When set to true, allow the user to provide one-letter input
> + with a single key (i.e., without hitting the Enter key) in
> + interactive commands. This is currently used by the `--patch`
> + mode of linkgit:git-add[1], linkgit:git-checkout[1],
> linkgit:git-restore[1], linkgit:git-commit[1],
> linkgit:git-reset[1], and linkgit:git-stash[1].
>
The resulting text reads well.
Nicely done.
next prev parent reply other threads:[~2024-05-22 21:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 21:24 [PATCH v2] doc: imply that interactive.singleKey is disabled by default Dragan Simic
2024-05-22 21:31 ` Junio C Hamano [this message]
2024-05-22 21:34 ` Dragan Simic
2024-05-31 0:49 ` Dragan Simic
2024-05-31 17:23 ` Junio C Hamano
2024-05-31 22:21 ` Dragan Simic
2024-06-04 20:11 ` Dragan Simic
2024-06-07 22:15 ` Junio C Hamano
2024-06-08 9:59 ` Dragan Simic
2024-06-07 22:27 ` [PATCH v3] doc: " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy1811qkx.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
--cc=rjusto@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).