git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Michael Lohmann <mial.lohmann@gmail.com>
Cc: l.s.r@web.de,  Elijah Newren <newren@gmail.com>,
	 Michael Lohmann <mi.al.lohmann@gmail.com>,
	 git@vger.kernel.org
Subject: Re: [PATCH 1/2] Documentation/git-merge.txt: fix reference to synopsis
Date: Wed, 20 Dec 2023 12:56:22 -0800	[thread overview]
Message-ID: <xmqqy1dor3t5.fsf@gitster.g> (raw)
In-Reply-To: <20231220195342.17590-2-mi.al.lohmann@gmail.com> (Michael Lohmann's message of "Wed, 20 Dec 2023 20:53:41 +0100")

Michael Lohmann <mial.lohmann@gmail.com> writes:

> Also the previous version did not acknowledge that `--no-merge` would
> result in the precondition being fulfilled (thanks to Elijah Newren and
> Junio C Hamano for pointing that out).

This does not belong to the log message.  Please write for those who
only read "git log" output after the work is merged and nothing
else.  To them, errors in the previous attempt that was pointed out
by reviewers and corrected in this version do not exist.

It is perfectly fine to write something like the above after the
three-dash line.  That is the place to clue reviewers about the
context of this round, reminding what happend in the previous
iteration and what the differences this round has, etc.

Thanks.



  parent reply	other threads:[~2023-12-20 20:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-20  7:05 [PATCH] Documentation/git-merge.txt: fix reference to synopsys Michael Lohmann
2023-12-20 15:43 ` René Scharfe
2023-12-20 16:29   ` Elijah Newren
2023-12-20 17:18     ` René Scharfe
2023-12-20 16:51   ` Junio C Hamano
2023-12-20 19:53   ` [PATCH 0/2] Documentation/git-merge.txt: fix reference to synopsis Michael Lohmann
2023-12-20 19:53   ` [PATCH 1/2] " Michael Lohmann
2023-12-20 20:45     ` Elijah Newren
2023-12-20 20:56     ` Junio C Hamano [this message]
2023-12-20 21:35       ` [PATCH v3 " Michael Lohmann
2023-12-20 21:39         ` Junio C Hamano
2023-12-20 22:09           ` Michael Lohmann
2023-12-20 19:53   ` [PATCH 2/2] Documentation/git-merge.txt: use backticks for command wrapping Michael Lohmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy1dor3t5.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    --cc=mi.al.lohmann@gmail.com \
    --cc=mial.lohmann@gmail.com \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).