From: Junio C Hamano <gitster@pobox.com>
To: "Théo Maillart" <tmaillart@gmail.com>
Cc: "Théo MAILLART via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] rebase: introduce allow-inline-reword option
Date: Tue, 02 Aug 2022 15:36:06 -0700 [thread overview]
Message-ID: <xmqqy1w6e0ix.fsf@gitster.g> (raw)
In-Reply-To: <2a7040a4-20ce-495d-4182-089c6c08fbd6@gmail.com> ("Théo Maillart"'s message of "Wed, 3 Aug 2022 00:22:56 +0200")
Théo Maillart <tmaillart@gmail.com> writes:
> So, if I understand your suggestion correctly, we can say that,
> most of the logic is implemented in this patch, but I should move
> the "inline" logic from the "reword" to a new action "retitle".
Yeah, I was hoping that most of the logic has already been written,
except that it is likely you just ignored the original log message
and overwrote it with the single line you got, but now you need to
read the original and replace only the title (the "paragraph" before
the first blank line), which you may not have yet.
next prev parent reply other threads:[~2022-08-02 22:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 6:39 [PATCH] rebase: introduce allow-inline-reword option Théo MAILLART via GitGitGadget
2022-08-02 15:23 ` Junio C Hamano
2022-08-02 22:22 ` Théo Maillart
2022-08-02 22:36 ` Junio C Hamano [this message]
2022-08-02 22:59 ` Eric Sunshine
2022-08-03 14:16 ` Phillip Wood
2022-08-04 7:57 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy1w6e0ix.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=tmaillart@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).