git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Philip Oakley <philipoakley@iee.email>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
	Edmundo Carmona Antoranz <eantoranz@gmail.com>,
	whydoubt@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH v2] blame: report correct number of lines in progress when using ranges
Date: Fri, 08 Apr 2022 11:16:11 -0700	[thread overview]
Message-ID: <xmqqy20fmoes.fsf@gitster.g> (raw)
In-Reply-To: <9920b355-9003-e7c7-77ab-3432651674e9@iee.email> (Philip Oakley's message of "Fri, 8 Apr 2022 09:03:55 +0100")

Philip Oakley <philipoakley@iee.email> writes:

>> But I do not object to being more explicit.
>
> The core point though was that it can be misunderstood, thus avoiding
> the indirection, as you say, makes it more explicit for the reader.

Yup.  FWIW, I was saying that what the author wrote was not _wrong_
per-se.  I agree that being explicit here (instead of hiding behind
a pronoun) is an improvement.

Thanks.

  reply	other threads:[~2022-04-08 18:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-04 18:21 [PATCH v2] blame: report correct number of lines in progress when using ranges Edmundo Carmona Antoranz
2022-04-04 18:25 ` Edmundo Carmona Antoranz
2022-04-04 19:32   ` Junio C Hamano
2022-04-05  7:34 ` Bagas Sanjaya
2022-04-05  7:46   ` Ævar Arnfjörð Bjarmason
2022-04-05  7:55     ` Edmundo Carmona Antoranz
2022-04-05  9:42   ` Philip Oakley
2022-04-06 15:14     ` Junio C Hamano
2022-04-08  8:03       ` Philip Oakley
2022-04-08 18:16         ` Junio C Hamano [this message]
2022-04-05  9:36 ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy20fmoes.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=bagasdotme@gmail.com \
    --cc=eantoranz@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=philipoakley@iee.email \
    --cc=whydoubt@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).