From: Junio C Hamano <gitster@pobox.com>
To: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Cc: whydoubt@gmail.com, Git List <git@vger.kernel.org>
Subject: Re: [PATCH v2] blame: report correct number of lines in progress when using ranges
Date: Mon, 04 Apr 2022 12:32:58 -0700 [thread overview]
Message-ID: <xmqqy20kprth.fsf@gitster.g> (raw)
In-Reply-To: <CAOc6etaY8enMF0nmhaqA2+Oi6JmYFY-bPqsUFTXE=K8aFoXDnQ@mail.gmail.com> (Edmundo Carmona Antoranz's message of "Mon, 4 Apr 2022 20:25:59 +0200")
Edmundo Carmona Antoranz <eantoranz@gmail.com> writes:
> On Mon, Apr 4, 2022 at 8:21 PM Edmundo Carmona Antoranz
> <eantoranz@gmail.com> wrote:
>>
>> When using ranges, use their sizes as the limit for progress
>> instead of the size of the full file.
>>
>> '
>>
>> +test_expect_success 'blame progress on a full file' '
>> + cat >progress.txt <<-\EOF &&
>> + a simple test file
>> +
>> + no relevant content is expected here
>> +
>> + If the file is too short, we cannot test ranges
>> +
>> + EOF
>> + git add progress.txt &&
>> + git commit -m "add a file for testing progress" &&
>
> I wonder if the preceding section should be kept in a
> separate 'setup test'?
I actually wonder why we need a *new* test file to run this test,
instead of reusing what we already use in the existing test.
>
>> + GIT_PROGRESS_DELAY=0 \
>> + git blame --progress progress.txt > /dev/null 2> full_progress.txt &&
Style:
git blame --progress progress.txt >/dev/null 2>full_progress.txt &&
next prev parent reply other threads:[~2022-04-04 21:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 18:21 [PATCH v2] blame: report correct number of lines in progress when using ranges Edmundo Carmona Antoranz
2022-04-04 18:25 ` Edmundo Carmona Antoranz
2022-04-04 19:32 ` Junio C Hamano [this message]
2022-04-05 7:34 ` Bagas Sanjaya
2022-04-05 7:46 ` Ævar Arnfjörð Bjarmason
2022-04-05 7:55 ` Edmundo Carmona Antoranz
2022-04-05 9:42 ` Philip Oakley
2022-04-06 15:14 ` Junio C Hamano
2022-04-08 8:03 ` Philip Oakley
2022-04-08 18:16 ` Junio C Hamano
2022-04-05 9:36 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy20kprth.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=eantoranz@gmail.com \
--cc=git@vger.kernel.org \
--cc=whydoubt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).