From mboxrd@z Thu Jan  1 00:00:00 1970
From: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v5 0/6] tag: move PGP verification code to tag.c
Date: Wed, 06 Apr 2016 09:39:39 -0700
Message-ID: <xmqqy48qy9mc.fsf@gitster.mtv.corp.google.com>
References: <1459872449-7537-1-git-send-email-santiago@nyu.edu>
Mime-Version: 1.0
Content-Type: text/plain
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
	Eric Sunshine <sunshine@sunshineco.com>
To: santiago@nyu.edu
X-From: git-owner@vger.kernel.org Wed Apr 06 18:39:53 2016
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1anqUh-0004XM-J7
	for gcvg-git-2@plane.gmane.org; Wed, 06 Apr 2016 18:39:51 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751120AbcDFQjq (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Wed, 6 Apr 2016 12:39:46 -0400
Received: from pb-smtp0.pobox.com ([208.72.237.35]:59443 "EHLO
	sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1750943AbcDFQjp (ORCPT <rfc822;git@vger.kernel.org>);
	Wed, 6 Apr 2016 12:39:45 -0400
Received: from sasl.smtp.pobox.com (unknown [127.0.0.1])
	by pb-smtp0.pobox.com (Postfix) with ESMTP id C32A8526BF;
	Wed,  6 Apr 2016 12:39:41 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc
	:subject:references:date:in-reply-to:message-id:mime-version
	:content-type; s=sasl; bh=t+CQYO7lgZWnhYPivpWYfHGH7nU=; b=EQ121X
	Xn6UNCOn4Y973hunZuAHRK1Xfs7hhJZjSR13Uq88dy7DthcPZIku9BrrjmwYEEFb
	iO45z0IV4+V6o3Tu7pyObARjsC/glOUMajgUUs1y/MxT4zO62eHOYyv/xCnyTUYe
	35IJJRenKB0Ys3cU3ZDdN8/w8mwJDa9KeZduk=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc
	:subject:references:date:in-reply-to:message-id:mime-version
	:content-type; q=dns; s=sasl; b=I9n6v2YEf5FGxwAqNKZ+xIeyzC1O4XY8
	8h5gAgdenYgKX5iWsG7VNqRcLCMsoqfvIoN1+A5QFOAzob0VKJc+jmrv7mH4OkRT
	6B33QBXZwUW7lGHn1/QdVKPCouMjhXlyQrOwQoPNPpxhiir0yodIw7HM1lrpdwUu
	t3JdQwFgNfY=
Received: from pb-smtp0.int.icgroup.com (unknown [127.0.0.1])
	by pb-smtp0.pobox.com (Postfix) with ESMTP id B6EE4526BE;
	Wed,  6 Apr 2016 12:39:41 -0400 (EDT)
Received: from pobox.com (unknown [104.132.1.64])
	(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	by pb-smtp0.pobox.com (Postfix) with ESMTPSA id A9170526BB;
	Wed,  6 Apr 2016 12:39:40 -0400 (EDT)
In-Reply-To: <1459872449-7537-1-git-send-email-santiago@nyu.edu>
	(santiago@nyu.edu's message of "Tue, 5 Apr 2016 12:07:23 -0400")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
X-Pobox-Relay-ID: 28BC5B02-FC16-11E5-8070-45AF6BB36C07-77302942!pb-smtp0.pobox.com
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/290849>

The first three looked almost good.  I do not fully agree with what
4/6 does, and update to its function signature is likely to require
updates to 5/6 and 6/6.

Thanks.