From: Junio C Hamano <gitster@pobox.com>
To: slavomir vlcek <svlc@inventati.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] SubmittingPatches: fix an inconsistency
Date: Thu, 13 Nov 2014 10:20:50 -0800 [thread overview]
Message-ID: <xmqqy4rf0xod.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <5463FB4C.2060203@inventati.org> (slavomir vlcek's message of "Thu, 13 Nov 2014 01:29:00 +0100")
slavomir vlcek <svlc@inventati.org> writes:
> The 'SubmittingPatches' document contains a small inconsistency
> in a patch-email sending procedure.
>
> Not a big thing,
> but a newcomer could get confused.
>
> Please,
> also consider adding the definition/explanation for all the branches available
> at the beginning of this document (and maybe even what their names stand for).
> Thanks.
>
> Signed-off-by: slavomir vlcek <svlc@inventati.org>
> ---
>
> From 74859712cf805663e3863686bdc09511c74b207b Mon Sep 17 00:00:00 2001
> From: slavomir vlcek <svlc@inventati.org>
> Date: Thu, 13 Nov 2014 00:18:39 +0100
> Subject: [PATCH] SubmittingPatches: fix an inconsistency
>
> At line 213 there was an instruction:
> "re-send it with "To:" set to the maintainer [*1*] and "cc:" the list [*2*]"
>
> and this instruction got repeated once more in the document (line 340):
> "Send it to the list and cc the maintainer."
>
> This inconsistency was solved by editing the second occurance.
> ---
The same comment applies to the log message part.
Will queue; no need to resend.
Thanks.
> Documentation/SubmittingPatches | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index e6d46ed..fa71b5f 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -337,7 +337,7 @@ suggests to the contributors:
> spend their time to improve your patch. Go back to step (2).
>
> (4) The list forms consensus that the last round of your patch is
> - good. Send it to the list and cc the maintainer.
> + good. Send it to the maintainer and cc the list.
>
> (5) A topic branch is created with the patch and is merged to 'next',
> and cooked further and eventually graduates to 'master'.
next prev parent reply other threads:[~2014-11-13 18:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 22:07 [PATCH/RFC] builtin: move builtin retrieval to get_builtin() slavomir vlcek
2014-11-13 0:29 ` [PATCH] SubmittingPatches: fix an inconsistency slavomir vlcek
2014-11-13 18:20 ` Junio C Hamano [this message]
2014-11-13 18:28 ` Junio C Hamano
2014-11-13 18:30 ` Junio C Hamano
2014-11-13 21:41 ` slavomir vlcek
2014-11-13 18:19 ` [PATCH/RFC] builtin: move builtin retrieval to get_builtin() Junio C Hamano
2014-11-16 23:33 ` Slavomir Vlcek
2014-11-17 16:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy4rf0xod.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=svlc@inventati.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).