Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Srujith A Poojary via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Srujith A Poojary <poojarysrujith@gmail.com>
Subject: Re: [PATCH v3 0/2] [Outreachy PATCH] archive: remove USE_THE_REPOSITORY_VARIABLE from archival modules
Date: Tue, 10 Nov 2026 11:17:22 -0800	[thread overview]
Message-ID: <xmqqzevgqywt.fsf@gitster.g> (raw)
In-Reply-To: <pull.2305.v3.git.1794335969.gitgitgadget@gmail.com> (Srujith A. Poojary via GitGitGadget's message of "Tue, 10 Nov 2026 18:39:27 +0000")

"Srujith A Poojary via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> Refactored archive-tar.c, archive-zip.c, archive.c, and supporting files to
> use explicit struct repository *repo pointers instead of global repository
> variables.

It is not considered good manners to send a new iteration before
first finishing the discussion on the reviews you received on your
previous iteration.  You respond to reviews, saying "I will fix this
point", "I think this one is fine as-is because...", and so forth,
wait for responses to your response, and eventually come to an
agreement with those in the discussion, so both sides know what the
next iteration should look like before you start working on it.

Only after finishing all of that do you prepare and send a new
iteration.

Thanks.

  parent reply	other threads:[~2026-11-10 19:17 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 19:04 [PATCH 0/2] [Outreachy PATCH] archive: remove USE_THE_REPOSITORY_VARIABLE from archival modules Srujith A Poojary via GitGitGadget
2026-11-09 19:04 ` [PATCH 1/2] submodule: use the submodule repository to abbreviate commits Srujith A Poojary via GitGitGadget
2026-11-09 19:05 ` [PATCH 2/2] archive: remove USE_THE_REPOSITORY_VARIABLE from archival modules Srujith A Poojary via GitGitGadget
2026-11-09 20:45   ` Junio C Hamano
2026-11-10  8:13     ` Srujith Poojary
2026-11-10  6:03 ` [PATCH v2 0/2] [Outreachy PATCH] " Srujith A Poojary via GitGitGadget
2026-11-10  6:03   ` [PATCH v2 1/2] submodule: use the submodule repository to abbreviate commits Srujith A Poojary via GitGitGadget
2026-11-10  6:03   ` [PATCH v2 2/2] archive: remove USE_THE_REPOSITORY_VARIABLE from archival modules Srujith A Poojary via GitGitGadget
2026-11-10 16:07     ` Junio C Hamano
2026-11-10 18:33       ` Srujith Poojary
2026-11-10 18:39 ` [PATCH v3 0/2] [Outreachy PATCH] " Srujith A Poojary via GitGitGadget
2026-11-10 18:39   ` [PATCH v3 1/2] submodule: use the submodule repository to abbreviate commits Srujith A Poojary via GitGitGadget
2026-11-10 20:26     ` Junio C Hamano
2026-11-11  4:19       ` Srujith Poojary
2026-11-10 18:39   ` [PATCH v3 2/2] archive: remove USE_THE_REPOSITORY_VARIABLE from archival modules Srujith A Poojary via GitGitGadget
2026-11-10 20:40     ` Junio C Hamano
2026-11-11  4:17       ` Srujith Poojary
2026-11-11  8:34       ` Srujith Poojary
2026-11-10 19:17   ` Junio C Hamano [this message]
2026-11-11  8:25 ` [PATCH v4] " Srujith A Poojary via GitGitGadget
2026-11-11 11:08   ` Karthik Nayak
2026-11-11 12:24     ` Srujith Poojary
2026-11-11 12:45 ` [PATCH v5] archive-tar: add comments explaining configuration precedence Srujith A Poojary via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzevgqywt.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=poojarysrujith@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox