Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 5/5] t: allow testing with a non-default object storage foramt
Date: Fri, 06 Nov 2026 10:59:00 -0800	[thread overview]
Message-ID: <xmqqzevliy6j.fsf@gitster.g> (raw)
In-Reply-To: <20261105-pks-storage-format-improvements-v1-5-870bb4212518@pks.im> (Patrick Steinhardt's message of "Thu, 05 Nov 2026 16:02:06 +0100")

Patrick Steinhardt <ps@pks.im> writes:

> Subject: Re: [PATCH 5/5] t: allow testing with a non-default object storage foramt

"foramt" -> "format".

> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index a893963f86c..7fdd8272162 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -576,9 +576,13 @@ export EDITOR
>  GIT_TEST_BUILTIN_HASH=$("$GIT_BINARY" version --build-options | sed -ne 's/^default-hash: //p')
>  GIT_DEFAULT_HASH="${GIT_TEST_DEFAULT_HASH:-$GIT_TEST_BUILTIN_HASH}"
>  export GIT_DEFAULT_HASH
> +
>  GIT_DEFAULT_REF_STORAGE_FORMAT="${GIT_TEST_DEFAULT_REF_STORAGE_FORMAT:-files}"
>  export GIT_DEFAULT_REF_STORAGE_FORMAT

This unrelated change created unnecessary conflicts.

No need to resend.

>  
> +GIT_DEFAULT_OBJECT_STORAGE_FORMAT="${GIT_TEST_DEFAULT_OBJECT_STORAGE_FORMAT:-files}"
> +export GIT_DEFAULT_OBJECT_STORAGE_FORMAT
> +
>  # Tests using GIT_TRACE typically don't want <timestamp> <file>:<line> output
>  GIT_TRACE_BARE=1
>  export GIT_TRACE_BARE

  reply	other threads:[~2026-11-06 18:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 15:02 [PATCH 0/5] Improvements for storage format handling Patrick Steinhardt
2026-11-05 15:02 ` [PATCH 1/5] refs: create leading directories Patrick Steinhardt
2026-11-06 10:37   ` Karthik Nayak
2026-11-06 11:01     ` Patrick Steinhardt
2026-11-05 15:02 ` [PATCH 2/5] odb/files: " Patrick Steinhardt
2026-11-05 15:02 ` [PATCH 3/5] setup: allow speciyfing payloads with default storage formats Patrick Steinhardt
2026-11-05 15:02 ` [PATCH 4/5] builtin/rev-parse: print payload for the ref storage format Patrick Steinhardt
2026-11-06 10:40   ` Karthik Nayak
2026-11-05 15:02 ` [PATCH 5/5] t: allow testing with a non-default object storage foramt Patrick Steinhardt
2026-11-06 18:59   ` Junio C Hamano [this message]
2026-11-06 10:41 ` [PATCH 0/5] Improvements for storage format handling Karthik Nayak
2026-11-06 11:02   ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzevliy6j.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox