Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Venkat Ragavan via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Karthik Nayak <karthik.188@gmail.com>,
	Patrick Steinhardt <ps@pks.im>,
	Harald Nordgren <haraldnordgren@gmail.com>,
	"D. Ben Knoble" <ben.knoble@gmail.com>,
	Venkat Ragavan <mail2venkat21@gmail.com>
Subject: Re: [PATCH] refs: fix loose-ref seeking across directory boundaries
Date: Tue, 27 Oct 2026 15:22:48 -0700	[thread overview]
Message-ID: <xmqqzevyg4w7.fsf@gitster.g> (raw)
In-Reply-To: <pull.2258.git.1792067455341.gitgitgadget@gmail.com> (Venkat Ragavan via GitGitGadget's message of "Thu, 15 Oct 2026 12:30:55 +0000")

"Venkat Ragavan via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Venkat Ragavan S <mail2venkat21@gmail.com>
>
> When seeking through loose refs, cache_ref_iterator_seek() compares
> each directory component without its trailing slash. This can confuse
> a directory with a similarly named ref that sorts before it.
> ...
> Add regression tests for shared-prefix names, missing nested markers,
> and markers beyond the end of the ref listing, using loose, packed,
> and mixed refs.
>
> Signed-off-by: Venkat Ragavan S <mail2venkat21@gmail.com>
> ---
>     refs: fix loose-ref seeking across directory boundaries

I overlooked this topic, but re-reading the discussion, aside from a
test that confused a reader, it seems the topic was already ready to
go?

Any objections to the idea of making the topic ready for 'next'?

Thanks.

  parent reply	other threads:[~2026-10-27 22:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 12:30 [PATCH] refs: fix loose-ref seeking across directory boundaries Venkat Ragavan via GitGitGadget
2026-10-15 13:36 ` Harald Nordgren
2026-10-15 17:08   ` D. Ben Knoble
     [not found]     ` <CAFuK-oaFyp7QdA=Nrc68cNx1iu803pQSUOZ=f947rRjWbJ7Z5w@mail.gmail.com>
2026-10-15 19:04       ` D. Ben Knoble
2026-10-15 19:13   ` Junio C Hamano
2026-10-15 21:17     ` Harald Nordgren
     [not found]       ` <CAFuK-obau8UkmVVs0xkuwjddkqftMxwcGnGR640YqjswGrTj3Q@mail.gmail.com>
2026-10-16  3:19         ` Venkat Ragavan
2026-10-27 22:22 ` Junio C Hamano [this message]
2026-10-28  8:58   ` Patrick Steinhardt
2026-10-28 16:26     ` Junio C Hamano
2026-10-28  8:57 ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzevyg4w7.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=haraldnordgren@gmail.com \
    --cc=karthik.188@gmail.com \
    --cc=mail2venkat21@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox