Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org,
	 "brian m . carlson" <sandals@crustytoothpaste.net>,
	 Patrick Steinhardt <ps@pks.im>,
	 Elijah Newren <newren@gmail.com>,  Jeff King <peff@peff.net>,
	 Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 00/13] SHA-1/SHA-256 interoperability, part 3: pack index v3
Date: Wed, 21 Oct 2026 12:01:11 -0700	[thread overview]
Message-ID: <xmqqzew6naiw.fsf@gitster.g> (raw)
In-Reply-To: <20261021063245.2917625-1-christian.couder@gmail.com> (Christian Couder's message of "Wed, 21 Oct 2026 08:32:32 +0200")

Christian Couder <christian.couder@gmail.com> writes:

> My `Signed-off-by: ...` was added only to the changed patches.

Please read DCO again; it is fairly clear on what you need to do in
cases like this:

    b. The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

    c. The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

b. covers the ones you changed. c. covers the ones you are relaying.
You need to sign both kinds off.

>  - Patches 1 and 4 are adapted to `ps/odb-files-alternates`. There is
>    now a single `odb->source`, so `odb_map_oid()` and
>    `odb_write_oid_map()` just dispatch to it. The files backend checks
>    each of its object directories in turn (main directory first, then
>    alternates) and writes mappings into the main directory, like it
>    does for objects. The `read_alternates` callbacks are dropped, as
>    the topic removed them.

Thanks for rebasing these (and all others), and

>  - Patches 7, 8, 11 and 12 now also add tests to t1016 for the
>    problems fixed in them, which were not covered before. They use a
>    new small `create_compat_repo()` helper introduced in patch 7.

adding tests and generally polishing them.


  parent reply	other threads:[~2026-10-21 19:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21  6:32 [PATCH 00/13] SHA-1/SHA-256 interoperability, part 3: pack index v3 Christian Couder
2026-10-21  6:32 ` [PATCH 01/13] loose: allow looking up in object map with source Christian Couder
2026-10-21  6:32 ` [PATCH 02/13] loose: rename repo_add_loose_object_map Christian Couder
2026-10-21  6:32 ` [PATCH 03/13] loose: add a flag to control whether we write mapped OIDs Christian Couder
2026-10-21  6:32 ` [PATCH 04/13] odb: implement interoperability functions Christian Couder
2026-10-21  6:32 ` [PATCH 05/13] object-file-convert: implement mapping in terms of object DB Christian Couder
2026-10-21  6:32 ` [PATCH 06/13] pack-write: add support for pack index v3 Christian Couder
2026-10-21  6:32 ` [PATCH 07/13] builtin: populate pack index v3 fields when indexing Christian Couder
2026-10-21  6:32 ` [PATCH 08/13] object-file: handle compatibility algorithm Christian Couder
2026-10-21  6:32 ` [PATCH 09/13] packfile: add support for reading pack index v3 Christian Couder
2026-10-21  6:32 ` [PATCH 10/13] packfile: validate pack index v3 tables Christian Couder
2026-10-21  6:32 ` [PATCH 11/13] loose: map object IDs using pack index v3 Christian Couder
2026-10-21  6:32 ` [PATCH 12/13] packfile: allow looking up compat object IDs in packs Christian Couder
2026-10-21  6:32 ` [PATCH 13/13] doc: move pack index v3 documentation Christian Couder
2026-10-21 19:01 ` Junio C Hamano [this message]
2026-10-23  7:34   ` [PATCH 00/13] SHA-1/SHA-256 interoperability, part 3: pack index v3 Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzew6naiw.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox