Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Cc: Usman Akinyemi <usmanakinyemi202@gmail.com>,
	 Shashank S via GitGitGadget <gitgitgadget@gmail.com>,
	 git@vger.kernel.org,
	 Christian Couder <christian.couder@gmail.com>,
	 Siddharth Asthana <siddharthasthana31@gmail.com>,
	 Shashank S <shashu8660@gmail.com>
Subject: Re: [PATCH] t0081: modernize the code testing whether a file exists
Date: Thu, 15 Oct 2026 10:10:08 -0700	[thread overview]
Message-ID: <xmqqzeweopov.fsf@gitster.g> (raw)
In-Reply-To: <9c905a79-22a2-4db2-b434-00ad8a287300@gmail.com> (Kaartic Sivaraam's message of "Thu, 15 Oct 2026 17:13:33 +0530")

Kaartic Sivaraam <kaartic.sivaraam@gmail.com> writes:

> That said, I just wanted to highlight one thing. In the Microproject 
> ideas page[1], we have the following for this specific idea:
>
>    Notes
>
>    - Start small: Pick a test file with just a few instances to convert
>    - Run the test suite after your changes to ensure nothing breaks
>    - Follow Git’s commit message style
>    - Include which command you used to find the instances in your commit
>      message
>
> So, we can't really blame the candidates for including the command in 
> the commit message. It is our mistake asking them to include it in the 
> first place when we don't prefer it to be present there.
>
> I raised a PR to fix that:
>
>    https://github.com/git/git.github.io/pull/875

I do not think your update is taking us in the right direction,
though.  Recommend to have it under three-dash lines instead,
perhaps?

  reply	other threads:[~2026-10-15 17:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14  7:26 [PATCH] t0081: modernize the code testing whether a file exists Shashank S via GitGitGadget
2026-10-14  9:49 ` Usman Akinyemi
2026-10-14 21:47   ` Junio C Hamano
2026-10-15  7:02     ` Shashank S
2026-10-15 11:43     ` Kaartic Sivaraam
2026-10-15 17:10       ` Junio C Hamano [this message]
2026-10-15  6:51   ` Shashank S
2026-10-15 10:47 ` [PATCH v2] [Outreachy] " Shashank S via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzeweopov.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=kaartic.sivaraam@gmail.com \
    --cc=shashu8660@gmail.com \
    --cc=siddharthasthana31@gmail.com \
    --cc=usmanakinyemi202@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox