Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org,  Jeff King <peff@peff.net>
Subject: Re: [PATCH 8/8] ci: drop redundant linux-reftable job
Date: Thu, 08 Oct 2026 11:18:14 -0700	[thread overview]
Message-ID: <xmqqzewoys2h.fsf@gitster.g> (raw)
In-Reply-To: <20261008-pks-ci-housekeeping-v1-8-baf015c589c0@pks.im> (Patrick Steinhardt's message of "Thu, 08 Oct 2026 12:01:26 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> The "linux-reftable" job exercises Git with reftables as its default
> backend. But this job is arguably redundant because we already have the
> "linux-reftable-leaks" job that exercises reftables with the leak
> sanitizer enabled, and it is unlikely that we will catch any extra bugs
> with the leak sanitizer disabled.
>
> Drop the job.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  .github/workflows/main.yml | 3 ---
>  .gitlab-ci.yml             | 3 ---
>  ci/run-build-and-tests.sh  | 2 +-
>  3 files changed, 1 insertion(+), 7 deletions(-)

As linux-reftable-leaks job uses NO_{CVS,SVN,PR}_TESTS in ci/lib.sh
to disable tests on these foreign-scm interoperability tests, this
change means reftable is no longer tested with them at all, no?

Not that I personally see specific value in testing git-p4 with both
reftable and reffiles backend, the loss of coverage needs to be
noted, if not justified, in the proposed commit log message.

Other than that, nice thinking.

Thanks.

  reply	other threads:[~2026-10-08 18:18 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-08 10:01 [PATCH 0/8] ci: some housekeeping and modernizations Patrick Steinhardt
2026-10-08 10:01 ` [PATCH 1/8] t5004: skip SHA-1-only test in SHA-256 repository Patrick Steinhardt
2026-10-08 18:05   ` Junio C Hamano
2026-10-09  5:46     ` Patrick Steinhardt
2026-10-08 10:01 ` [PATCH 2/8] ci: fix "fedora-breaking-changes-meson" job Patrick Steinhardt
2026-10-08 10:01 ` [PATCH 3/8] ci: drop unused "linux-clang" logic Patrick Steinhardt
2026-10-08 10:01 ` [PATCH 4/8] ci: switch away from unsupported i386/ubuntu image Patrick Steinhardt
2026-10-08 15:03   ` Todd Zullinger
2026-10-08 18:12     ` Junio C Hamano
2026-10-09  5:46       ` Patrick Steinhardt
2026-10-08 10:01 ` [PATCH 5/8] ci: rename linux-TEST-vars job Patrick Steinhardt
2026-10-08 10:01 ` [PATCH 6/8] ci: switch away from EOL'd Ubuntu version in linux-exotic Patrick Steinhardt
2026-10-08 10:01 ` [PATCH 7/8] ci: drop now-dead Python 2 coverage Patrick Steinhardt
2026-10-08 10:01 ` [PATCH 8/8] ci: drop redundant linux-reftable job Patrick Steinhardt
2026-10-08 18:18   ` Junio C Hamano [this message]
2026-10-09  5:55     ` Patrick Steinhardt
2026-10-09 20:22       ` Junio C Hamano
2026-10-09 11:31 ` [PATCH v2 0/8] ci: some housekeeping and modernizations Patrick Steinhardt
2026-10-09 11:31   ` [PATCH v2 1/8] t5004: skip SHA-1-only test in SHA-256 repository Patrick Steinhardt
2026-10-09 11:31   ` [PATCH v2 2/8] ci: fix "fedora-breaking-changes-meson" job Patrick Steinhardt
2026-10-09 11:32   ` [PATCH v2 3/8] ci: drop unused "linux-clang" logic Patrick Steinhardt
2026-10-09 11:32   ` [PATCH v2 4/8] ci: switch away from unsupported i386/ubuntu image Patrick Steinhardt
2026-10-09 11:32   ` [PATCH v2 5/8] ci: rename linux-TEST-vars job Patrick Steinhardt
2026-10-09 15:31     ` SZEDER Gábor
2026-10-09 11:32   ` [PATCH v2 6/8] ci: switch away from EOL'd Ubuntu version in linux-exotic Patrick Steinhardt
2026-10-09 11:32   ` [PATCH v2 7/8] ci: drop now-dead Python 2 coverage Patrick Steinhardt
2026-10-09 11:32   ` [PATCH v2 8/8] ci: improve reftable test coverage Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzewoys2h.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox