From: Junio C Hamano <gitster@pobox.com>
To: "Mark C. Chu-Carroll" <markchucarroll@fastmail.com>
Cc: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>,
<git@vger.kernel.org>, <peff@peff.net>, <newren@gmail.com>,
"Derrick Stolee" <stolee@gmail.com>
Subject: Re: [PATCH 1/6] strbuf: add header for 'safe' API
Date: Wed, 23 Sep 2026 13:14:34 -0700 [thread overview]
Message-ID: <xmqqzex7913p.fsf@gitster.g> (raw)
In-Reply-To: <DLMXXKPGU78J.2PBDFYJTPFTA4@fastmail.com> (Mark C. Chu-Carroll's message of "Wed, 23 Sep 2026 15:25:23 -0400")
"Mark C. Chu-Carroll" <markchucarroll@fastmail.com> writes:
> General comment: I really like the idea of this. While I haven't
> encountered this specific issue with git, I've dealt with similar issues
> in other systems, and even if the cascading error case is rare, it's
> incredibly frustrating to deal with the loss of error details because
> they used unsafe operations to generate their messages!
If I understand correctly what this topic aims at, you'll see the
"loss of error details" either way. Either we ran out of memory
inside strbuf call and die, or we fail to allocate memory to format
the details and end up not showing it.
> On Fri Sep 18, 2026 at 9:02 AM EDT, Derrick Stolee via GitGitGadget wrote:
>> From: Derrick Stolee <stolee@gmail.com>
>>
>> In particular, we cannot include 'banned-die.h' in 'strbuf.c'.
>
> I think we prefer to avoid "we" in these comments; and
The third word of your comment should not be "we" but "I", if that
"we" intends to include me and others who wrote many commit log
messages ;-)
next prev parent reply other threads:[~2026-09-23 20:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 13:02 [PATCH 0/6] [RFC] Create a 'safe' strbuf API Derrick Stolee via GitGitGadget
2026-09-18 13:02 ` [PATCH 1/6] strbuf: add header for 'safe' API Derrick Stolee via GitGitGadget
2026-09-21 21:18 ` Junio C Hamano
2026-09-23 19:25 ` Mark C. Chu-Carroll
2026-09-23 20:14 ` Junio C Hamano [this message]
2026-09-18 13:02 ` [PATCH 2/6] wrapper: initialize GIT_ALLOC_LIMIT proactively Derrick Stolee via GitGitGadget
2026-09-18 13:02 ` [PATCH 3/6] wrapper: create safe_memory_limit_check() Derrick Stolee via GitGitGadget
2026-09-21 21:24 ` Junio C Hamano
2026-09-18 13:02 ` [PATCH 4/6] strbuf-safe: add sstrbuf_grow() Derrick Stolee via GitGitGadget
2026-09-21 21:29 ` Junio C Hamano
2026-09-18 13:02 ` [PATCH 5/6] json-writer: include strbuf-safe.h Derrick Stolee via GitGitGadget
2026-09-18 13:02 ` [PATCH 6/6] strbuf-safe: add init and release methods Derrick Stolee via GitGitGadget
2026-09-21 21:44 ` Junio C Hamano
2026-09-21 22:34 ` Junio C Hamano
2026-09-19 15:23 ` [PATCH 0/6] [RFC] Create a 'safe' strbuf API Phillip Wood
2026-09-23 19:46 ` Jeff King
2026-10-06 14:33 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzex7913p.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=markchucarroll@fastmail.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox