From: Junio C Hamano <gitster@pobox.com>
To: Tian Yuchen <cat@malon.dev>
Cc: git@vger.kernel.org, ps@pks.im, phillip.wood123@gmail.com,
johannes.schindelin@gmx.de, stolee@gmail.com
Subject: Re: [PATCH v3 0/2] environment: move ignore_case into repo_config_values
Date: Mon, 22 Jun 2026 11:01:20 -0700 [thread overview]
Message-ID: <xmqqzf0mzc7j.fsf@gitster.g> (raw)
In-Reply-To: <b5a9115a-c909-405f-b150-f956d866b1eb@malon.dev> (Tian Yuchen's message of "Tue, 23 Jun 2026 00:45:46 +0800")
Tian Yuchen <cat@malon.dev> writes:
> On 6/22/26 04:16, Junio C Hamano wrote:
>> As the compat/ layer is not meant as a general purpose POSIX
>> emulation wrapper that is generally reusable to projects other than
>> us, if we have a knob settable by end users to affect behaviours of
>> lower layer in compat/, it is natural to make repo-settings
>> available to them.
>
> I see.
>
>> What is the perceived problem you have in mind, and what are your
>> proposed alternatives?
>
> Actually, my reason for showing this question wasn’t because I thought
> there were any architectural problem, but because I felt that for a file
> in compat/win32, which is more on the _downstream_ side (is that
> correct?), we need to exercise extra caution and confirm with its
> maintainer whether the changes are appropriate. That’s why I CC'd
> Johannes Schindelin on this.
>
> Was that the right thing to do?
Yup, Dscho is the right person to decide on the design issues on
Windows build.
prev parent reply other threads:[~2026-06-22 18:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 15:49 [PATCH 0/2] environment: move ignore_case into repo_config_values Tian Yuchen
2026-06-17 15:49 ` [PATCH 1/2] " Tian Yuchen
2026-06-17 17:16 ` Junio C Hamano
2026-06-18 10:56 ` Tian Yuchen
2026-06-17 15:49 ` [PATCH 2/2] config: use repo_get_ignore_case() to access core.ignorecase Tian Yuchen
2026-06-18 11:42 ` [PATCH v2 0/2] environment: move ignore_case into repo_config_values Tian Yuchen
2026-06-18 11:42 ` [PATCH v2 1/2] " Tian Yuchen
2026-06-18 11:42 ` [PATCH v2 2/2] config: use repo_ignore_case() to access core.ignorecase Tian Yuchen
2026-06-18 13:14 ` [PATCH v2 0/2] environment: move ignore_case into repo_config_values Junio C Hamano
2026-06-19 16:01 ` Tian Yuchen
2026-06-19 15:51 ` [PATCH v3 " Tian Yuchen
2026-06-19 15:51 ` [PATCH v3 1/2] " Tian Yuchen
2026-06-19 15:51 ` [PATCH v3 2/2] config: use repo_ignore_case() to access core.ignorecase Tian Yuchen
2026-06-21 20:16 ` [PATCH v3 0/2] environment: move ignore_case into repo_config_values Junio C Hamano
2026-06-22 16:45 ` Tian Yuchen
2026-06-22 18:01 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzf0mzc7j.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=cat@malon.dev \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=phillip.wood123@gmail.com \
--cc=ps@pks.im \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox