Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] build: tolerate use of _Generic from glibc 2.43 with Clang
Date: Mon, 11 May 2026 12:23:11 +0900	[thread overview]
Message-ID: <xmqqzf26sk80.fsf@gitster.g> (raw)
In-Reply-To: <20260505-b4-pks-ci-tolerate-glibc-generic-v1-1-5786386fe512@pks.im> (Patrick Steinhardt's message of "Tue, 05 May 2026 14:26:03 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> Instead, work around the issue by not using -std=gnu99 with Clang when
> using the Makefile and by disabling warnings about C11 extensions when
> using Meson. This isn't ideal, but we at least retain the ability to
> detect the (mis-)use of features from newer standards with GCC.
>
> An alternative to this might be to simply bump the required C standard
> to C11, which is 15 years old by now and should have support on most
> platforms out there. But some more esoteric platforms may not have it.

Wouldn't the approach you took on the meson side to pass
"-Wno-c11-extensions" be yet another alternative?  I think that is
what the other proposal (which was only for Makefile world and not
for meson world) did, even though it may not have been a great
implemenation to help only those who use config.mak.dev

   <pull.2291.git.git.1778120192298.gitgitgadget@gmail.com>

We would need a patch to apply at lesat on v2.54.0 but possibly
older tracks if we plan to keep them also buildable.

Thanks.

  reply	other threads:[~2026-05-11  3:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-05 12:26 [PATCH] build: tolerate use of _Generic from glibc 2.43 with Clang Patrick Steinhardt
2026-05-11  3:23 ` Junio C Hamano [this message]
2026-05-11  5:20   ` Junio C Hamano
2026-05-11  5:46     ` Patrick Steinhardt
2026-05-11  6:10       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzf26sk80.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox