From: Junio C Hamano <gitster@pobox.com>
To: kristofferhaugsbakk@fastmail.com
Cc: git@vger.kernel.org, Kristoffer Haugsbakk <code@khaugsbakk.name>
Subject: Re: [PATCH v2] doc: patch-id: fix accidental literal blocks
Date: Mon, 29 Sep 2025 15:18:05 -0700 [thread overview]
Message-ID: <xmqqzfac6gyq.fsf@gitster.g> (raw)
In-Reply-To: <v2-e5ad12cc3b3.1759178715.git.code@khaugsbakk.name> (kristofferhaugsbakk@fastmail.com's message of "Mon, 29 Sep 2025 22:47:28 +0200")
kristofferhaugsbakk@fastmail.com writes:
> From: Kristoffer Haugsbakk <code@khaugsbakk.name>
>
> All the final paragraphs on these three options are rendered as
> literal blocks. The intent was surely to keep each of them wed to their
> respective description list items. But the attempt at maintaining the
> indentation level of the block causes each them to be interpreted as a
> code block, since code blocks can be represented using indentation.
>
> We need to use list continuation (+) in order to keep them wed to
> their blocks.
>
> There is also an unordered list which sandwiches two paragraphs on an
> option. We don’t need to do anything about that since it attaches to the
> description list item without list continuation (i.e. it is already
> correct). But for consistency let’s use list continuation and an open
> block on it.
>
> Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
> ---
Thanks. Let me mark this for 'next'.
prev parent reply other threads:[~2025-09-29 22:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-28 14:03 [PATCH] doc: patch-id: fix accidental literal blocks kristofferhaugsbakk
2025-09-28 15:45 ` Kristoffer Haugsbakk
2025-09-28 16:01 ` Junio C Hamano
2025-09-28 19:25 ` Kristoffer Haugsbakk
2025-09-28 19:37 ` Junio C Hamano
2025-09-29 20:47 ` [PATCH v2] " kristofferhaugsbakk
2025-09-29 22:18 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzfac6gyq.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).