git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Gustavo Velasco-Hernández via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
	"Gustavo Velasco-Hernández" <gustavo.velascoh@gmail.com>,
	"Velasco-Hernandez,
	Gustavo" <Gustavo.Velasco-Hernandez@netapp.com>
Subject: Re: [PATCH v2] docs: update description for '--mirror' option for 'git push'
Date: Tue, 16 Sep 2025 10:19:08 -0700	[thread overview]
Message-ID: <xmqqzfaumi2b.fsf@gitster.g> (raw)
In-Reply-To: <pull.2028.v2.git.git.1758038628948.gitgitgadget@gmail.com> ("Gustavo Velasco-Hernández via GitGitGadget"'s message of "Tue, 16 Sep 2025 16:03:48 +0000")

"Gustavo Velasco-Hernández via GitGitGadget"
<gitgitgadget@gmail.com> writes:

> From: "Velasco-Hernandez, Gustavo" <Gustavo.Velasco-Hernandez@netapp.com>
> Signed-off-by: Gustavo Velasco-Hernandez <gustavo.velascoh@gmail.com>

For this project to use a patch, these two must match.

Please decide, under which name do you want to be known as to this
community.  Once you decide, please use that chosen name to
configure user.name and user.email for the repository you use to
work on Git, amend the commit and update the sign-off using the same
identity, and the force push to GitGitGadget to /submit (I am not
sure about the last two steps as I am not a GGG user)?

> The current description considers only created, updated or deleted refs
> locally. However it does not address the case where new refs were created
> on the remote end, in which case, are also deleted. The description has
> been reworded to describe what is removed, updated or added. (Based on
> Junio feedback)

Drop "(Based on Junio feedback)" that is not even grammatical ;-)
If you want to credit others, it is common to say

    Helped-by: ...

just before your own sign-off.  See an example like

https://lore.kernel.org/git/2f78ab2e28c64f05d807cb9460fa62eb1011a57f.1757879060.git.code@khaugsbakk.name/

(by the way, oh, gee, that's an unwieldy long message ID).

>  Documentation/git-push.adoc | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/git-push.adoc b/Documentation/git-push.adoc
> index 5f5408e2c0..77ce4a27c8 100644
> --- a/Documentation/git-push.adoc
> +++ b/Documentation/git-push.adoc
> @@ -163,12 +163,11 @@ already exists on the remote side.
>  	Instead of naming each ref to push, specifies that all
>  	refs under `refs/` (which includes but is not
>  	limited to `refs/heads/`, `refs/remotes/`, and `refs/tags/`)
> -	be mirrored to the remote repository.  Newly created local
> -	refs will be pushed to the remote end, locally updated refs
> -	will be force updated on the remote end, and deleted refs
> -	will be removed from the remote end.  This is the default
> -	if the configuration option `remote.<remote>.mirror` is
> -	set.
> +	be mirrored to the remote repository. This overwrites the
> +	refs at the remote by (1) removing what is only at the remote,
> +	(2) force-updating what both ends of the connection have, and
> +	(3) adding what only exists locally. This is the default if
> +	the configuration option `remote.<remote>.mirror` is set.

Reads very clearly.  Thanks.

  reply	other threads:[~2025-09-16 17:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-11 14:34 [PATCH] docs: update description for '--mirror' option for 'git push' Gustavo Velasco-Hernández via GitGitGadget
2025-08-11 16:41 ` Junio C Hamano
2025-09-16 16:03 ` [PATCH v2] " Gustavo Velasco-Hernández via GitGitGadget
2025-09-16 17:19   ` Junio C Hamano [this message]
2025-09-16 20:04     ` Kristoffer Haugsbakk
2025-09-18 20:58       ` Kristoffer Haugsbakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzfaumi2b.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Gustavo.Velasco-Hernandez@netapp.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gustavo.velascoh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).