From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org, Emily Shaffer <nasamuffin@google.com>
Cc: Jacob Stopak <jacob@initialcommit.io>
Subject: Re: [PATCH] Include gettext.h in MyFirstContribution tutorial
Date: Wed, 18 Oct 2023 14:35:17 -0700 [thread overview]
Message-ID: <xmqqzg0fpqay.fsf@gitster.g> (raw)
In-Reply-To: <20231017041503.3249-1-jacob@initialcommit.io> (Jacob Stopak's message of "Mon, 16 Oct 2023 21:15:03 -0700")
Jacob Stopak <jacob@initialcommit.io> writes:
> The tutorial in Documentation/MyFirstContribution.txt has steps to print
> some text using the "_" function. However, this leads to compiler errors
> when running "make" since "gettext.h" is not #included.
>
> Update docs with a note to #include "gettext.h" in "builtin/psuh.c".
>
> Signed-off-by: Jacob Stopak <jacob@initialcommit.io>
> ---
> Documentation/MyFirstContribution.txt | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Who's the first responder on this document these days? I think the
"psuh" was Emily's invention, so sending it in her direction.
Thanks.
> diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt
> index 62d11a5cd7..7cfed60c2e 100644
> --- a/Documentation/MyFirstContribution.txt
> +++ b/Documentation/MyFirstContribution.txt
> @@ -160,10 +160,11 @@ in order to keep the declarations alphabetically sorted:
> int cmd_psuh(int argc, const char **argv, const char *prefix);
> ----
>
> -Be sure to `#include "builtin.h"` in your `psuh.c`.
> +Be sure to `#include "builtin.h"` in your `psuh.c`. You'll also need to
> +`#include "gettext.h"` to use functions related to printing output text.
>
> -Go ahead and add some throwaway printf to that function. This is a decent
> -starting point as we can now add build rules and register the command.
> +Go ahead and add some throwaway printf to the `cmd_psuh` function. This is a
> +decent starting point as we can now add build rules and register the command.
>
> NOTE: Your throwaway text, as well as much of the text you will be adding over
> the course of this tutorial, is user-facing. That means it needs to be
next prev parent reply other threads:[~2023-10-18 21:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 4:15 [PATCH] Include gettext.h in MyFirstContribution tutorial Jacob Stopak
2023-10-18 21:35 ` Junio C Hamano [this message]
2023-10-26 21:21 ` Emily Shaffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzg0fpqay.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob@initialcommit.io \
--cc=nasamuffin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).