git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Adam \\\"Sinus\\\" Skawiński" <adam.skawinski@sinpi.net>
Cc: git@vger.kernel.org
Subject: Re: receive.denyCurrentBranch=updateInstead won't update the repo
Date: Mon, 17 Jul 2023 13:52:19 -0700	[thread overview]
Message-ID: <xmqqzg3ugt18.fsf@gitster.g> (raw)
In-Reply-To: <CAGE71k3Ccm3hBrfNgXFqO9Zk0V9FkoskgD1ViJ6eSakxdBuqQQ@mail.gmail.com> ("Adam \"Sinus\" Skawiński"'s message of "Mon, 17 Jul 2023 22:26:26 +0200")

"Adam \"Sinus\" Skawiński"  <adam.skawinski@sinpi.net> writes:

> Note: The `push-to-checkout` hook doesn't seem to run, either, even
> though it's in the .git/hooks/push-to-checkout file, with +x rights as
> needed. I made it output some lines and exit with code 1, so it should
> abort after producing the output - and yet the pushes come through.
> Other hooks, like `update`, work fine and can abort if they exit 1.

I have nothing to offer offhand, but have you compared on the server
side your "update" and "push-to-checkout" hooks?  Even a simple typo
of the filename "push-to-checkout" would make it untable to run ;-).
Similarly to the name of the configuration variable, which is rather
long and prone to be mistyped.  After staring at a problem for a
long time getting frustrated, I myself would miss such a trivial
mistake, and would want to go back and double check just to be sure.

In fact, while trying to reproduce the problem with a simple pair of
repositories, I did manage to mistype denyCurrentBranch and saw that
the machinery not to kick in at all ;-).

  reply	other threads:[~2023-07-17 20:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17 20:26 receive.denyCurrentBranch=updateInstead won't update the repo Adam "Sinus" Skawiński
2023-07-17 20:52 ` Junio C Hamano [this message]
2023-07-17 21:09 ` Junio C Hamano
     [not found]   ` <CAGE71k2bdy2aYy7speu=OOStopgjzVNOPQ_-V-63aCURLibFWw@mail.gmail.com>
2023-07-17 22:26     ` Adam "Sinus" Skawiński
2023-07-18 22:20       ` Adam "Sinus" Skawiński
2023-07-18 22:28         ` Junio C Hamano
2023-07-18 22:49           ` Adam "Sinus" Skawiński
2023-07-18 23:03             ` Junio C Hamano
2023-07-18 23:29               ` Adam "Sinus" Skawiński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzg3ugt18.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=adam.skawinski@sinpi.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).