From: Junio C Hamano <gitster@pobox.com>
To: "D. Ben Knoble via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "D. Ben Knoble" <ben.knoble+github@gmail.com>
Subject: Re: [PATCH] t4002: fix "diff can read from stdin" syntax
Date: Fri, 14 Jul 2023 09:52:32 -0700 [thread overview]
Message-ID: <xmqqzg3yph9r.fsf@gitster.g> (raw)
In-Reply-To: <pull.1545.git.git.1689341410476.gitgitgadget@gmail.com> (D. Ben Knoble via GitGitGadget's message of "Fri, 14 Jul 2023 13:30:10 +0000")
"D. Ben Knoble via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: "D. Ben Knoble" <ben.knoble+github@gmail.com>
>
> I noticed this test was producing output like
>
> ```
> t4002-diff-basic.sh: test_expect_successdiff can read from stdin: not found
> ```
>
> which is rather odd. Investigation shows an error of shell syntax:
> foo'abc' is the same as fooabc to the shell. Perhaps obviously, this is
> not a valid command for the test.
>
> I am surprised this doesn't count as an error in the test, but that
> accounts for it going unnoticed.
>
> Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>
> ---
Nicely spotted. Thanks.
Will queue.
prev parent reply other threads:[~2023-07-14 16:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 13:30 [PATCH] t4002: fix "diff can read from stdin" syntax D. Ben Knoble via GitGitGadget
2023-07-14 14:44 ` René Scharfe
2023-07-14 14:53 ` D. Ben Knoble
2023-07-14 18:56 ` John Cai
2023-07-14 16:52 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzg3yph9r.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble+github@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).