git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] t3701: we don't need no Perl for `add -i` anymore
Date: Mon, 27 Mar 2023 10:40:03 -0700	[thread overview]
Message-ID: <xmqqzg7yaya4.fsf@gitster.g> (raw)
In-Reply-To: <pull.1504.git.1679898996492.gitgitgadget@gmail.com> (Johannes Schindelin via GitGitGadget's message of "Mon, 27 Mar 2023 06:36:36 +0000")

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> -if test_have_prereq !PERL
> -then
> -	skip_all='skipping add -i (scripted) tests, perl not available'
> -	test_done
> -fi
> -

The version before ab/retire-scripted-add-p partially touched this
line used to use !ADD_I_USE_BUILTIN,!PERL as the prerequisites, i.e.
"When we are not testing the built-in version, skip this script if
we do not have a working Perl".  Now we no longer have the scripted
one, the former half of the prerequisite is never satisified (i.e.
we are always testing the built-in version, and there is no reason
to see if Perl is available).

With this the topic becomes complete.  Very nice.

I read the changes other test scripts touched by the topic just to
double check, and it seems this was the only misconversion.  t2016
and t6132 had the same logic but spelled in different ways, and
there were converted correctly back then.

Will queue.  Thanks.

      reply	other threads:[~2023-03-27 17:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-27  6:36 [PATCH] t3701: we don't need no Perl for `add -i` anymore Johannes Schindelin via GitGitGadget
2023-03-27 17:40 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzg7yaya4.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).