From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/3] do full type check in COPY_ARRAY and MOVE_ARRAY
Date: Sun, 01 Jan 2023 21:11:59 +0900 [thread overview]
Message-ID: <xmqqzgb2fo8g.fsf@gitster.g> (raw)
In-Reply-To: <bf4e6798-c687-270d-1344-37bacb403e13@web.de> ("René Scharfe"'s message of "Sun, 1 Jan 2023 11:45:41 +0100")
René Scharfe <l.s.r@web.de> writes:
> On second thought, what do we gain by using __builtin_types_compatible_p
> here? Does it catch cases that the assignment check plus the element
> size check wouldn't?
I was reacting to this part of an earlier message in the thread:
Presumably we cannot catch
int *ip;
unsigned *up;
(0 ? (*(ip) = *(up), 0) : 0);
(0 ? (*(up) = *(ip), 0) : 0);
with the approach?
i.e. *ip and *up are of the same size. Would the assignment check
trigger?
> We actually need to compare the types of the elements here, because
> otherwise we'd disallow copies between arrays (int arr[7]) and pointers
> (int *p), which would be unnecessarily strict.
Yup. Thanks for inferring what I meant to give, despite the two
typoes (the other one is ", 0").
next prev parent reply other threads:[~2023-01-01 12:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 21:51 [PATCH 0/3] COPY_ARRAY, MOVE_ARRAY, DUP_ARRAY René Scharfe
2022-12-30 21:56 ` [PATCH 1/3] do full type check in COPY_ARRAY and MOVE_ARRAY René Scharfe
2023-01-01 3:03 ` Junio C Hamano
2023-01-01 3:59 ` Junio C Hamano
2023-01-01 7:41 ` René Scharfe
2023-01-01 10:45 ` René Scharfe
2023-01-01 12:11 ` Junio C Hamano [this message]
2023-01-01 12:32 ` René Scharfe
2023-01-01 12:46 ` Junio C Hamano
2022-12-30 22:02 ` [PATCH 2/3] add DUP_ARRAY René Scharfe
2022-12-30 22:03 ` [PATCH 3/3] use DUP_ARRAY René Scharfe
2023-01-01 21:05 ` [PATCH v2 0/4] COPY_ARRAY, MOVE_ARRAY, DUP_ARRAY René Scharfe
2023-01-01 21:08 ` [PATCH v2 1/4] factor out BARF_UNLESS_COPYABLE René Scharfe
2023-01-01 21:11 ` [PATCH v2 2/4] do full type check in BARF_UNLESS_COPYABLE René Scharfe
2023-01-08 7:28 ` Junio C Hamano
2023-01-08 10:10 ` René Scharfe
2023-01-09 4:27 ` Junio C Hamano
2023-01-09 18:08 ` Jeff Hostetler
2023-01-01 21:14 ` [PATCH v2 3/4] add DUP_ARRAY René Scharfe
2023-01-01 21:16 ` [PATCH v2 4/4] use DUP_ARRAY René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzgb2fo8g.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).