From: Junio C Hamano <gitster@pobox.com>
To: "Daniel Li" <dan@danielyli.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Phillip Wood" <phillip.wood@dunelm.org.uk>,
"René Scharfe" <l.s.r@web.de>
Cc: git@vger.kernel.org
Subject: Re: Bug: `git show` honors path filters only for the first commit
Date: Fri, 29 Apr 2022 21:59:58 -0700 [thread overview]
Message-ID: <xmqqzgk388tt.fsf@gitster.g> (raw)
In-Reply-To: <CAHVT7hW28jMcphDPhcUG==mycCWDaAt46wWo68=oTcSvebHWwg@mail.gmail.com> (Daniel Li's message of "Fri, 29 Apr 2022 19:22:06 -0700")
Daniel Li <dan@danielyli.com> writes:
> git version: 2.36.0
> OS: macOS Monterey 12.2.1
> Installed via: homebrew
I think this is the same regression as the recently talked about
"diff-tree --stdin" aka "gitk" regression.
https://lore.kernel.org/git/xmqq7d7bsu2n.fsf@gitster.g/
e900d494 (diff: add an API for deferred freeing, 2021-02-11), broke
cmd_log_walk(), and we started to lose some setting that was parsed
from the command line and stored in the diff_options structure after
cmd_log_walk() runs just once. But "git show A B" runs the function
once for each commit. A recent change in 2.36.0 made it worse by
adding <pathspec> to the set of setting that gets lost after
cmd_log_walk() runs once.
Thanks for a report.
next prev parent reply other threads:[~2022-04-30 5:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-30 2:22 Bug: `git show` honors path filters only for the first commit Daniel Li
2022-04-30 4:59 ` Junio C Hamano [this message]
2022-04-30 5:29 ` [PATCH] 2.36 show regression fix Junio C Hamano
2022-04-30 10:32 ` [PATCH] 2.36 format-patch " René Scharfe
2022-04-30 16:32 ` Carlo Marcelo Arenas Belón
2022-05-01 9:35 ` René Scharfe
2022-05-20 15:23 ` the state of diff_free() and release_revisions() (was: [PATCH] 2.36 format-patch regression fix) Ævar Arnfjörð Bjarmason
2022-05-20 17:23 ` the state of diff_free() and release_revisions() Junio C Hamano
2022-04-30 14:31 ` [PATCH] 2.36 fast-export regression fix René Scharfe
2022-04-30 20:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzgk388tt.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=dan@danielyli.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).