From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Elijah Newren <newren@gmail.com>,
Git Mailing List <git@vger.kernel.org>, Thomas Hurst <tom@hur.st>
Subject: Re: Corrupt name-rev output
Date: Sat, 23 Apr 2022 09:47:56 -0700 [thread overview]
Message-ID: <xmqqzgkb21c3.fsf@gitster.g> (raw)
In-Reply-To: <340c8810-d912-7b18-d46e-a9d43f20216a@web.de> ("René Scharfe"'s message of "Fri, 22 Apr 2022 20:44:40 +0200")
René Scharfe <l.s.r@web.de> writes:
> Subject: [PATCH] Revert "name-rev: release unused name strings"
>
> This reverts commit 2d53975488df195e1431c3f90bfb5b60018d5bf6.
>
> 3656f84278 (name-rev: prefer shorter names over following merges,
> 2021-12-04) broke the assumption of 2d53975488 (name-rev: release unused
> name strings, 2020-02-04) that a better name for a child is a better
> name for all of its ancestors as well, because it added a penalty for
> generation > 0. This leads to strings being free(3)'d that are still
> needed.
Nicely described.
Thanks.
next prev parent reply other threads:[~2022-04-23 16:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-17 16:20 Corrupt name-rev output Thomas Hurst
2022-04-20 3:13 ` Junio C Hamano
2022-04-21 2:11 ` Elijah Newren
2022-04-21 17:55 ` René Scharfe
2022-04-22 18:44 ` René Scharfe
2022-04-23 16:47 ` Junio C Hamano [this message]
2022-05-17 10:15 ` Ævar Arnfjörð Bjarmason
2022-05-17 16:20 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzgkb21c3.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=newren@gmail.com \
--cc=tom@hur.st \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).