From: Junio C Hamano <gitster@pobox.com>
To: heapcrash heapcrash <heapcrash@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Enhancing --show-function and --function-context in default configurations
Date: Sun, 01 Aug 2021 19:21:52 -0700 [thread overview]
Message-ID: <xmqqzgu0y4an.fsf@gitster.g> (raw)
In-Reply-To: <CAM1Tk15N6uK3aU5bY6mWQVX5UdEOraysrRmO+v4TA+P-Wa9_hQ@mail.gmail.com> (heapcrash heapcrash's message of "Sun, 1 Aug 2021 16:40:58 -0500")
heapcrash heapcrash <heapcrash@gmail.com> writes:
> gauge whether these changes would be accepted or not. As far as I can
> tell, these would not change the default behavior of plain git
> {grep,log,diff} unless the --show-function or --function-context flags
> are specified
Two other places may be diff hunk headers and --diff-words output, I think.
> Should I work on a patch that does this?
That depends. If you are going to introduce a mechanism to
introduce hardcoded configurations, depending on how it is done, it
will become a huge security headache.
next prev parent reply other threads:[~2021-08-02 2:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-01 21:40 Enhancing --show-function and --function-context in default configurations heapcrash heapcrash
2021-08-02 2:21 ` Junio C Hamano [this message]
2021-08-02 8:45 ` Ævar Arnfjörð Bjarmason
2021-08-02 16:17 ` Jeff King
2021-08-02 17:06 ` Junio C Hamano
2021-08-03 2:34 ` heapcrash heapcrash
2021-08-03 14:55 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzgu0y4an.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=heapcrash@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).