From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: Derrick Stolee <stolee@gmail.com>,
Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 3/3] diff: correct warning message when renameLimit exceeded
Date: Tue, 13 Jul 2021 17:47:28 -0700 [thread overview]
Message-ID: <xmqqzgupzppb.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BHF3Os7fOeaF_EQOo+Bs7f1DXbYr26WmAQrPjv63nq1Pg@mail.gmail.com> (Elijah Newren's message of "Mon, 12 Jul 2021 11:13:57 -0700")
Elijah Newren <newren@gmail.com> writes:
> On Mon, Jul 12, 2021 at 8:09 AM Derrick Stolee <stolee@gmail.com> wrote:
>>
>> Since the steps that find inexact renames without the quadratic
>> algorithm are heuristics, perhaps this portion could instead be
>> called "exhaustive rename detection" or even "expensive rename
>> detection"? It perhaps implies more directly that the limit exists
>> as a way to prevent an expensive operation.
>
> The name "exhaustive rename detection" seems reasonable to me. I'll
> resubmit using that term and see what folks think.
Funny. In a sense, since computing content similarity is _more_
precise way to find a pair that is a likely rename than the more
recent heuristics, the more expensive "exhaustive" one can be called
"more precise rename detection", even though it is tempting to use
"inexact" to call it, too ;-)
next prev parent reply other threads:[~2021-07-14 0:47 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 0:46 [PATCH 0/3] Improve the documentation and warnings dealing with rename/copy limits Elijah Newren via GitGitGadget
2021-07-11 0:46 ` [PATCH 1/3] doc: clarify documentation for " Elijah Newren via GitGitGadget
2021-07-11 4:37 ` Bagas Sanjaya
2021-07-11 4:52 ` Elijah Newren
2021-07-12 15:03 ` Derrick Stolee
2021-07-12 21:27 ` Junio C Hamano
2021-07-11 0:46 ` [PATCH 2/3] doc: document the special handling of -l0 Elijah Newren via GitGitGadget
2021-07-11 4:54 ` Eric Sunshine
2021-07-11 4:54 ` Elijah Newren
2021-07-11 0:46 ` [PATCH 3/3] diff: correct warning message when renameLimit exceeded Elijah Newren via GitGitGadget
2021-07-12 15:09 ` Derrick Stolee
2021-07-12 18:13 ` Elijah Newren
2021-07-14 0:47 ` Junio C Hamano [this message]
2021-07-14 1:06 ` Elijah Newren
2021-07-14 1:10 ` Junio C Hamano
2021-07-14 1:22 ` Elijah Newren
2021-07-14 5:17 ` Junio C Hamano
2021-07-14 15:09 ` Elijah Newren
2021-07-14 1:12 ` [PATCH v2 0/4] Rename/copy limits -- docs, warnings, and new defaults Elijah Newren via GitGitGadget
2021-07-14 1:12 ` [PATCH v2 1/4] diff: correct warning message when renameLimit exceeded Elijah Newren via GitGitGadget
2021-07-14 1:12 ` [PATCH v2 2/4] doc: clarify documentation for rename/copy limits Elijah Newren via GitGitGadget
2021-07-14 7:37 ` Ævar Arnfjörð Bjarmason
2021-07-14 16:30 ` Elijah Newren
2021-07-14 22:08 ` Ævar Arnfjörð Bjarmason
2021-07-14 22:56 ` Elijah Newren
2021-07-14 1:12 ` [PATCH v2 3/4] doc: document the special handling of -l0 Elijah Newren via GitGitGadget
2021-07-14 16:45 ` Jeff King
2021-07-14 17:17 ` Elijah Newren
2021-07-14 17:33 ` Jeff King
2021-07-14 19:32 ` Elijah Newren
2021-07-14 1:12 ` [PATCH v2 4/4] Bump rename limit defaults (yet again) Elijah Newren via GitGitGadget
2021-07-14 16:43 ` Jeff King
2021-07-14 17:32 ` Elijah Newren
2021-07-14 17:57 ` Jeff King
2021-07-14 20:03 ` Elijah Newren
2021-07-14 20:47 ` Jeff King
2021-07-15 0:45 ` [PATCH v3 0/4] Rename/copy limits -- docs, warnings, and new defaults Elijah Newren via GitGitGadget
2021-07-15 0:45 ` [PATCH v3 1/4] diff: correct warning message when renameLimit exceeded Elijah Newren via GitGitGadget
2021-07-15 0:45 ` [PATCH v3 2/4] doc: clarify documentation for rename/copy limits Elijah Newren via GitGitGadget
2021-07-15 0:45 ` [PATCH v3 3/4] diffcore-rename: treat a rename_limit of 0 as unlimited Elijah Newren via GitGitGadget
2021-07-15 23:17 ` Junio C Hamano
2021-07-15 0:45 ` [PATCH v3 4/4] Bump rename limit defaults (yet again) Elijah Newren via GitGitGadget
2021-07-15 13:36 ` [PATCH v3 0/4] Rename/copy limits -- docs, warnings, and new defaults Derrick Stolee
2021-07-15 23:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzgupzppb.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=newren@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).