git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Emma Brooks <me@pluvano.com>
Cc: git@vger.kernel.org, Eric Wong <e@80x24.org>
Subject: Re: [PATCH] Documentation: explain "mboxrd" pretty format
Date: Thu, 16 Apr 2020 19:00:58 -0700	[thread overview]
Message-ID: <xmqqzhbax44l.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200417014713.GA20574@pluvano.com> (Emma Brooks's message of "Fri, 17 Apr 2020 01:47:13 +0000")

Emma Brooks <me@pluvano.com> writes:

> On 2020-04-15 22:03:36-0700, Junio C Hamano wrote:
>> > +Like 'email', but lines in the commit message starting with "From "
>> > +(preceded by zero or more ">") are quoted with ">" so they aren't
>> > +confused as starting a new commit.
>> 
>> I am torn between rephrasing "starting a new commit" with "starting
>> a new e-mail message", and keeping it as-is.  Technically, the latter
>> is more correct---the >From quoting is a technique to avoid starting
>> a line with "From " in a reversible way, as pieces of e-mails in a
>> single mailbox file needs to be split at the boundary.  But in the
>> context of format-patch, perhaps saying each "record" in the output
>> file is a "commit" (not a piece of e-mail message) would probably be
>> an acceptable white lie.
>
> While it is more accurate to say "starting a new email" rather than
> "commit", I think it might be less confusing to say "starting a new
> commit", if the reader isn't already familiar with how mbox works or its
> variants, since the pretty formats control commit display and would
> typically be thought about in terms of commits rather than emails.

Exactly.  That is why I said that I was torn between technical
correctness and tool-specific description.  "torn between" is quite
different from "inclined to prefer the one different from yours" ;-)


      reply	other threads:[~2020-04-17  2:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-16  4:16 [PATCH] Documentation: explain "mboxrd" pretty format Emma Brooks
2020-04-16  4:44 ` Eric Wong
2020-04-16  5:03 ` Junio C Hamano
2020-04-17  1:47   ` Emma Brooks
2020-04-17  2:00     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzhbax44l.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=e@80x24.org \
    --cc=git@vger.kernel.org \
    --cc=me@pluvano.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).