From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] test-lib-functions: make packetize() more efficient
Date: Sun, 29 Mar 2020 08:44:46 -0700 [thread overview]
Message-ID: <xmqqzhbzb1xt.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200329145343.GB15400@coredump.intra.peff.net> (Jeff King's message of "Sun, 29 Mar 2020 10:53:43 -0400")
Jeff King <peff@peff.net> writes:
> On Sat, Mar 28, 2020 at 08:05:10PM -0700, Junio C Hamano wrote:
>
>> -- >8 --
>> Subject: CodingGuidelines: allow ${#posix} == strlen($posix)
>
> I'm in favor of this patch, but...
>
>> The construct has been in POSIX for the past 10+ years, and we have
>> used in t9xxx (subversion) series of the tests, so we know it is at
>> least portable across systems that subversion Perl bindings have
>> been ported to.
>
> It is even stronger than that. t9010 is run for everybody (with the
> exception of the last test, which needs svnadmin).
Ah, you're right. Lemme make it stronger.
The construct has been in POSIX for the past 10+ years, and we have
used in t9xxx (subversion) series of the tests, so we know it is at
portable across systems that people have run those tests, which is
almost everything we'd care about.
Thanks.
next prev parent reply other threads:[~2020-03-29 15:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 8:02 [PATCH 0/2] upload-pack: handle unexpected v2 delim packets Jeff King
2020-03-27 8:03 ` [PATCH 1/2] test-lib-functions: make packetize() more efficient Jeff King
2020-03-27 15:16 ` Taylor Blau
2020-03-28 12:25 ` Jeff King
2020-03-27 19:18 ` Junio C Hamano
2020-03-28 11:20 ` Jeff King
2020-03-29 0:11 ` Junio C Hamano
2020-03-29 3:05 ` Junio C Hamano
2020-03-29 14:53 ` Jeff King
2020-03-29 15:44 ` Junio C Hamano [this message]
2020-03-29 14:52 ` Jeff King
2020-03-29 15:02 ` [PATCH] test-lib-functions: simplify packetize() stdin code Jeff King
2020-03-29 15:49 ` Junio C Hamano
2020-03-27 8:03 ` [PATCH 2/2] upload-pack: handle unexpected delim packets Jeff King
2020-03-27 15:17 ` Taylor Blau
2020-03-27 15:18 ` [PATCH 0/2] upload-pack: handle unexpected v2 " Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzhbzb1xt.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).