From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Jonathan Tan <jonathantanmy@google.com>,
matvore@google.com, git@vger.kernel.org
Subject: Re: [PATCH] rev-list: allow cached objects in existence check
Date: Tue, 05 Mar 2019 22:33:13 +0900 [thread overview]
Message-ID: <xmqqzhq9tpie.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190304211749.GA3020@sigill.intra.peff.net> (Jeff King's message of "Mon, 4 Mar 2019 16:17:49 -0500")
Jeff King <peff@peff.net> writes:
>> Or teach git-blame to have its own pretend mechanism, and remove the
>> pretend mechanism from sha1-file.c.
>
> I think that would be ideal, but I'm not sure if it's feasible due to
> the layering of the various modules.
Sorry, but I do not get why we want command-line specific pretend
mechanism. When one part of the system wants to behave as if object
X exists, doesn't that part want other parts of the system to share
that same world view to be consistent?
I am mostly reacting to "would be _ideal_"; if it were "if we have
per-system ad-hoc pretend mechanism, things like this and that would
become easier to implement, even though that is an ugly hack", I may
agree when I see examples of things that get easier, though.
next prev parent reply other threads:[~2019-03-05 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 17:40 [PATCH] rev-list: allow cached objects in existence check Jeff King
2019-03-04 19:19 ` Jonathan Tan
2019-03-04 21:17 ` Jeff King
2019-03-05 13:33 ` Junio C Hamano [this message]
2019-03-05 19:27 ` Jeff King
2019-03-05 13:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzhq9tpie.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=matvore@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).